Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Fix for #3562 #4253

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Fix for #3562 #4253

merged 1 commit into from
Feb 20, 2019

Conversation

justinharrell
Copy link
Contributor

@justinharrell justinharrell commented Feb 14, 2019

Adds forEach to DataView, based on how map was implemented, just passes through but applies the dataview filter. See #3562

@justinharrell justinharrell changed the title Fox for #3562 Fix for #3562 Feb 14, 2019
@justinharrell
Copy link
Contributor Author

Seems to be failing lint because of 9de41d6

@softwareCobbler
Copy link

Seems to be failing lint because of 9de41d6

true; easy fix, too: #4256

@justinharrell
Copy link
Contributor Author

Should be good to go now after rebase

Copy link
Member

@mojoaxel mojoaxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojoaxel mojoaxel merged commit 320b180 into almende:develop Feb 20, 2019
mojoaxel pushed a commit to visjs/vis_original that referenced this pull request Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants