Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Network: Handle null data gracefully #3571

Merged
merged 2 commits into from
Oct 14, 2017
Merged

Network: Handle null data gracefully #3571

merged 2 commits into from
Oct 14, 2017

Commits on Oct 14, 2017

  1. Network: preload images in options for all shape types 

    Fixes almende#3532

If the images option is set, preload it, even if the node shape is not `image` or `circularImage`.
This needs to be done because the user can switch to an image shape later, as is happening in the issue.
Option `image` is only mandatory for the image shapes.

There is no unit test for this, because it would need a mock object for Image and I didn't succeed in creating/finding one.
    @wimrijnders
    wimrijnders committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    44b2a1d View commit details
    Browse the repository at this point in the history

  2. Network: Handle null data gracefully 

    During testing I discovered that passing `null` for network data leads to a thrown error.
This adds a guard to prevent it, plus unit tests for regression.
    @wimrijnders
    wimrijnders committed Oct 14, 2017
    Configuration menu
    Copy the full SHA
    8e8e176 View commit details
    Browse the repository at this point in the history