Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

Network: Retain constraint values in label font handling #3520

Merged
merged 6 commits into from
Oct 8, 2017

Commits on Oct 4, 2017

  1. Network: Retain constraint values in label font handling

    Fixes almende#3517.
    
    Due to changed logic in the label font handling, the option values for `widthConstraint` and `heightConstraint` were overwritten.
    The fix is in effect a reversal of two code lines: parsing constraint options should come *after* parsing (multi)font options.
    
    Further changes:
    
    - Additional 1-liner fix: constraint values were not copied for edge-instance specific options.
    - Small refactoriing of `Label#constrain()` in order to separate concerns
    - Added unit test for regression testing of this issue.
    
    This leads to the curious observation that, while the actual change is two lines of source code, this resulted in a +-150 line regression test.
    wimrijnders committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    5cf882b View commit details
    Browse the repository at this point in the history
  2. Fixed conflicts

    wimrijnders committed Oct 4, 2017
    Configuration menu
    Copy the full SHA
    352048f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2017

  1. Configuration menu
    Copy the full SHA
    481a556 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f246978 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    175e741 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4cd7286 View commit details
    Browse the repository at this point in the history