Fix trx logger parses suite (fixes #749) #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baev
requested changes
Oct 8, 2018
plugins/trx-plugin/src/main/java/io/qameta/allure/trx/TrxPlugin.java
Outdated
Show resolved
Hide resolved
plugins/trx-plugin/src/main/java/io/qameta/allure/trx/TrxPlugin.java
Outdated
Show resolved
Hide resolved
|
Your requested changes make sense. I included them. |
baev
requested changes
Oct 9, 2018
plugins/trx-plugin/src/main/java/io/qameta/allure/trx/UnitTest.java
Outdated
Show resolved
Hide resolved
|
@P-Hessler could you please rebase from master? |
Use String.format for concatenation
P-Hessler
force-pushed
the
Parse_Suite_in_Trx_Plugin
branch
from
5e07d1c to
b2fe7a6
Compare
|
I hope I didn't screw anything. It was my first time rebasing a fork. |
baev
approved these changes
Oct 9, 2018
|
@P-Hessler thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[//]: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Previously, the trx plugin read only the name of a test. Thereby, each test ended up in an own package/suite.
Now, the plugin reads the className attribute of the testMethod element in the trx files and stores this name as Suite, TestClass and Package. Furthermore, the className along with the name of the testMethod is used as FullName and HistoryId.
Checklist