Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump MSRV to 1.81 #790

Merged
merged 2 commits into from
Nov 28, 2024
Merged

chore: bump MSRV to 1.81 #790

merged 2 commits into from
Nov 28, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Oct 28, 2024

Reverts #789, reapplying #780 and #781.

@DaniPopes DaniPopes marked this pull request as ready for review November 28, 2024 16:45
@DaniPopes DaniPopes enabled auto-merge (squash) November 28, 2024 16:46
@DaniPopes DaniPopes merged commit d6ab70d into main Nov 28, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/msrv-1.81-2 branch November 28, 2024 16:54
@michaelsproul
Copy link

Just want to confirm, but your MSRV policy allows the MSRV to change for a patch release?

I think this is a matter of taste, but I was a bit surprised by this, because it means a cargo update can necessitate bumping the MSRV (which is the case for Lighthouse updating alloy right now). I can see why this is just simpler -- and we can definitely make it work -- just wanted to let you know that this is something we noticed.

@DaniPopes
Copy link
Member Author

Yes that is right, you can check out the policy in the READMEs of each repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants