fix(consensus): correct TxEip1559.encode_with_signature

[vbrvk]

Motivation

Fixing TxEip1559 encoding, before fix node reply with "error code -32602: Failed to decode transaction" error

Solution

The tx type byte was missing in encode_with_signature.encode_with_signature method

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[Evalir]

To produce a valid tx you need to encode the tx using a TxEnvelope, which will produce an EIP-2718 compliant tx and add the type byte which was missing. Same for decoding—you're expected to use the envelope (see tests).

[vbrvk]

How can it be used over abstract Transaction trait?

I have next method, how can i use TxEnvelope there?

    pub async fn sign_tx<T: Transaction<Signature = Signature>>(&self, mut tx: T) -> Result<Bytes> {
        let signature = self.local.sign_transaction(&mut tx).await?;

        dbg!(hex::encode(&signature.as_bytes()));
        let signed = TxEnvelope::from(tx.into_signed(signature));
        Ok(signed.into())
    }

Maybe it possible to add

const fn tx_type(&self) -> TxType

method to Transaction trait, so TxEnvelope can be created from any transaction?

[Evalir]

This is a good question—we're working on streamlining the flow from a TransactionRequest -> signing and converting to a TxEnvelope so it's easy to send transactions over the network with a provider, here: #190 . Right now this flow is not very well polished and it's probably why you found this issue.

The method you posted looks fine—as long as you encode the tx using a tx envelope then this should be working.