Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize w/ gta5 #168

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gottfriedleibniz
Copy link
Contributor

Some of the return types are still a bit weird, e.g., GET_NEAREST_PLAYER_... and the PARTICIPANT_ID ones.

@Halen84
Copy link
Contributor

Halen84 commented Oct 29, 2023

Finally getting back to this, and here I fixed all of the errors that I could find, and renamed a few natives:
natives.zip

@gottfriedleibniz
Copy link
Contributor Author

gottfriedleibniz commented Nov 16, 2023

Committed your changes and whatever else I had stashed. Although, I think it would be nice to split these changes into two separate commits:

  1. Mistakes in my change-set (mostly done automatically with an additional pass to manually salvage other commands that did not exactly match).
  2. Natives without gta_hash deemed worthy of synchronization (something I did not focus on).

Should make the commit history a little nicer and a tad easier to review. I'll likely squash everything after (Done).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants