SCRUM-3711 refactor #1486
Merged
SCRUM-3711 refactor #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to remove some classes SCRUM-3711.2
|
@markquintontulloch not sure which it should be for this conflict. |
oblodgett
approved these changes
Apr 3, 2024
|
@markquintontulloch was this a change in the code... |
|
@oblodgett No, that's been there a while. I keep meaning to address it as presumably that means we would get a 500 error rather than a 400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oblodgett There's almost certainly a cleaner way of doing this. The complication is that not all annotation service classes inherit from the same base service class. The AGMDiseaseAnnotationService, AlleleDiseaseAnnotationService, and GeneDiseaseAnnotationService classes all inherited from BaseDTOCrudService, whereas DiseaseAnnotationService and all the phenotype annotation service classes inherit from BaseEntityCrudService. No matter how I try to refactor I always end up with duplicate methods somewhere or unimplemented methods in multiple classes. There's probably something really basic that I'm missing though.