Globalize new variables after loading plugin file #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16. As noted there, this approach was previously implemented at https://l.alley.dev/c0cc8fb23c, which is derived from https://github.com/Automattic/vip-go-mu-plugins/blob/60780fee97674a77a9ada2b25ce6dd4b6ebbd583/vip-helpers/vip-utils.php#L1381-L1424.
Worth noting that even with this update, the plugin loader still can't correctly load the Disqus plugin, which was one that has been causing us difficulty: https://l.alley.dev/636711d9c8. The reason is that the Disqus plugin doesn't explicitly globalize the variable in question, but tries to reference it later in the plugin entry file with the
globalkeyword in function scope, the result being that we don't have any opportunity to actually globalize the variable before theglobalkeyword is used.