Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/wireup code page ctas #59

Merged
merged 6 commits into from
Jan 3, 2023
Merged

Feat/wireup code page ctas #59

merged 6 commits into from
Jan 3, 2023

Conversation

poomthiti
Copy link
Contributor

@poomthiti poomthiti commented Dec 30, 2022 •
edited
Loading

Describe your changes

(Code page) Wireup code name,description, and cta section

Demo Link

https://celatone-frontend-git-feat-wireup-code-ctas-alles-labs.vercel.app/code/4670

@vercel
Copy link

vercel bot commented Dec 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 4:28AM (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 4:28AM (UTC)

evilpeach
evilpeach requested changes Dec 31, 2022
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you create tickets for wiring up the uploader and WASM downloadable link?

@poomthiti
Copy link
Contributor Author

Do you create tickets for wiring up the uploader and WASM downloadable link?

Done

@poomthiti poomthiti requested a review from evilpeach January 2, 2023 07:42
evilpeach
evilpeach approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@poomthiti poomthiti merged commit 4607962 into develop Jan 3, 2023
@poomthiti poomthiti deleted the feat/wireup-code-ctas branch January 3, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp Awaiting requested review from songwongtp

@bkioshn bkioshn Awaiting requested review from bkioshn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poomthiti @evilpeach