Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support searching with hex addr and module path #562

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

poomthiti
Copy link
Contributor

Describe your changes

Demo Link

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging 🛑 Canceled (Inspect) Oct 20, 2023 9:08am
initia-celatone-frontend ❌ Failed (Inspect) Oct 20, 2023 9:08am
osmosis-celatone-frontend-staging ❌ Failed (Inspect) Oct 20, 2023 9:08am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
neutron-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:08am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:08am
sei-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:08am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:08am
terra-celatone-frontend ⬜️ Ignored (Inspect) Visit Preview Oct 20, 2023 9:08am


const enableModuleFetching = useMemo(
() =>
Boolean(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value is already a boolean no need to cast it again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be boolean | "" | undefined if you don't wrap it

@songwongtp
Copy link
Collaborator

@poomthiti @evilpeach

  • should we apply unpadHexAddress to the hexaddr result?
  • should block height really be searchable via hex or should we prevent it?

@evilpeach
Copy link
Collaborator

@poomthiti @evilpeach

  • should we apply unpadHexAddress to the hexaddr result?
  • should block height really be searchable via hex or should we prevent it?
  1. Yes, applying unpadHexAddress to the hexaddr would be a good move.
  2. It's preferable not to use hex string when searching for block numbers.

@poomthiti
Copy link
Contributor Author

I have prevented querying block height with hex, further advise on where should I apply unpad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants