Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test case for assetValue and funds #414

Merged
merged 11 commits into from
Jul 13, 2023
Merged

feat: add test case for assetValue and funds #414

merged 11 commits into from
Jul 13, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jun 30, 2023

Describe your changes

Add test for

  • utils/funds.ts
  • utils/assetValue.ts

Remove

  • utils/isDecimalNumber.ts
  • utils/number.ts

@vercel
Copy link

vercel bot commented Jun 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 4:22am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2023 4:22am
sei-celatone-frontend-staging 🔄 Building (Inspect) Jul 13, 2023 4:22am
terra-celatone-frontend-staging 🔄 Building (Inspect) Jul 13, 2023 4:22am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
mitosis-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
neutron-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
neutron-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
sei-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
sei-mobile-celatone ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
sei-testnet-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am
terra-celatone-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 4:22am

@bkioshn bkioshn requested review from poomthiti and songwongtp July 3, 2023 03:01
songwongtp
songwongtp previously requested changes Jul 3, 2023
View reviewed changes
@bkioshn bkioshn requested review from evilpeach and songwongtp July 6, 2023 05:13
@evilpeach evilpeach dismissed songwongtp’s stale review July 13, 2023 04:20

I've already reviewed on this.

@evilpeach evilpeach merged commit 26afea8 into develop Jul 13, 2023
@evilpeach evilpeach deleted the feat/test-asset-fund branch July 13, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@poomthiti poomthiti Awaiting requested review from poomthiti

@songwongtp songwongtp Awaiting requested review from songwongtp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkioshn @evilpeach @songwongtp