Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test for token.ts #406

Merged
merged 11 commits into from
Jul 4, 2023
Merged

feat: add test for token.ts #406

merged 11 commits into from
Jul 4, 2023

Conversation

songwongtp
Copy link
Collaborator

Describe your changes

  • add test cases for utils/formatter/token.ts

Demo Link

@vercel
Copy link

vercel bot commented Jun 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 7:41am
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
mitosis-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
neutron-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
sei-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
sei-mobile-celatone ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
sei-testnet-celatone-frontend ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
terra-celatone-frontend ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am
terra-celatone-frontend-staging ⬜️ Ignored (Inspect) Jul 3, 2023 7:41am

bkioshn
bkioshn reviewed Jun 27, 2023
View reviewed changes
bkioshn
bkioshn reviewed Jun 28, 2023
View reviewed changes
Copy link
Contributor

@bkioshn bkioshn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add more context about our test
eg. instead of

formatDecimal
    ✕ invalid (1 ms)

to

 formatDecimal
    Invalid
      ✓ String value (2 ms)
      ✓ NAN

@evilpeach @poomthiti

bkioshn
bkioshn suggested changes Jun 29, 2023
View reviewed changes
@songwongtp songwongtp requested a review from bkioshn June 30, 2023 06:40
Base automatically changed from feat/jest to develop June 30, 2023 07:15
evilpeach
evilpeach requested changes Jun 30, 2023
View reviewed changes
@evilpeach evilpeach merged commit a4c593c into develop Jul 4, 2023
@evilpeach evilpeach deleted the feat/jest-formatter-token branch July 4, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@bkioshn bkioshn bkioshn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songwongtp @evilpeach @bkioshn