Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove hardcode constant and use from config #359

Merged
merged 6 commits into from
Jun 6, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented May 26, 2023

Describe your changes

Remove hardcode constant and use from config
Include:

  • MAX_CONTRACT_NAME_LENGTH
  • MAX_CONTRACT_DESCRIPTION_LENGTH
  • MAX_CODE_NAME_LENGTH
  • MAX_PROPOSAL_TITLE_LENGTH
  • MAX_LIST_NAME_LENGTH

Also move helper function to utils include

  • getMaxLengthError to error.ts
  • getListIcon to icon.ts

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend 🔄 Building (Inspect) Jun 6, 2023 8:18am
mitosis-celatone-frontend-staging 🔄 Building (Inspect) Jun 6, 2023 8:18am
neutron-celatone-frontend-staging 🔄 Building (Inspect) Jun 6, 2023 8:18am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 8:18am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jun 6, 2023 8:18am
sei-celatone-frontend-staging ⬜️ Ignored (Inspect) Jun 6, 2023 8:18am
stargaze-celatone-frontend-staging ⬜️ Ignored (Inspect) Jun 6, 2023 8:18am
terra-celatone-frontend ⬜️ Ignored (Inspect) Jun 6, 2023 8:18am
terra-celatone-frontend-staging ⬜️ Ignored (Inspect) Jun 6, 2023 8:18am

@evilpeach evilpeach requested a review from poomthiti June 4, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants