Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: N/A token size #241

Merged
merged 5 commits into from
Mar 17, 2023
Merged

fix: N/A token size #241

merged 5 commits into from
Mar 17, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Mar 15, 2023

Describe your changes

Fix NAToken component size

@vercel
Copy link

vercel bot commented Mar 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 5:01AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 5:01AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 5:01AM (UTC)
4 Ignored Deployments
Name Status Preview Comments Updated
beeb-celatone-frontend ⬜️ Ignored (Inspect) Mar 17, 2023 at 5:01AM (UTC)
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Mar 17, 2023 at 5:01AM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Mar 17, 2023 at 5:01AM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Mar 17, 2023 at 5:01AM (UTC)

@bkioshn bkioshn requested review from poomthiti and songwongtp March 15, 2023 06:01
@poomthiti
Copy link
Contributor

In TokenCard component: If h="101px" is there in order to set the minimum height of the card, use minH instead so the component can flex responsively

@poomthiti poomthiti self-requested a review March 16, 2023 04:30
@bkioshn bkioshn requested a review from evilpeach March 17, 2023 02:30
@evilpeach evilpeach changed the title fix: natoken size fix: N/A token size Mar 17, 2023
evilpeach
evilpeach requested changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update branch to latest commit

@bkioshn bkioshn merged commit 3473e1e into develop Mar 17, 2023
@bkioshn bkioshn deleted the fix/na-token-icon branch March 17, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp songwongtp approved these changes

@poomthiti poomthiti poomthiti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkioshn @poomthiti @evilpeach @songwongtp