Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page/Tx-details #226

Merged
merged 19 commits into from
Apr 5, 2023
Merged

Page/Tx-details #226

merged 19 commits into from
Apr 5, 2023

Conversation

poomthiti
Copy link
Contributor

@poomthiti poomthiti commented Feb 27, 2023 •
edited
Loading

Describe your changes

Main features

  1. Route and page setup for transaction details
  2. useTxData hook
  3. Top section
  4. Side section (TxInfo)
  5. Message handling switch cases and related components
  6. Token card value display
  7. Transaction not found ui

Minor changes

  1. Minor refactoring and improvements of some component/hook

Demo Link

https://osmosis-celatone-frontend-staging-git-pages-tx-page-alleslabs.vercel.app/testnet/tx/3D8EA04FE7E38E879D7B05B004E69B17E6D00B8F02806A8A89E5AE583D682370

@vercel
Copy link

vercel bot commented Feb 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
celatone-demo-terra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 6:46am
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview ✅ 2 resolved Apr 5, 2023 6:46am
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 6:46am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
beeb-celatone-frontend ⬜️ Ignored (Inspect) Apr 5, 2023 6:46am
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Apr 5, 2023 6:46am
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Apr 5, 2023 6:46am
terra-celatone-frontend ⬜️ Ignored (Inspect) Apr 5, 2023 6:46am

songwongtp
songwongtp requested changes Mar 1, 2023
View reviewed changes
@traviolus
Copy link
Contributor

We have a comma-separated value for the Gas Used/Requested field in the Figma design na. Does not exist in this PR.

screenshot_2023-03-07_at_2 22 03_pm

@traviolus
Copy link
Contributor

The Title field for /cosmos.gov.v1beta.MsgSubmitProposal is missing its value. See more here https://osmosis-celatone-frontend-staging-git-pages-tx-page-alleslabs.vercel.app/testnet/tx/186C2929D06F0D2921D4955A93C3C3929C2988685C62A0E3E4DA1104C80335DE

Screenshot 2023-03-07 at 2 41 25 PM

traviolus
traviolus requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@traviolus traviolus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix errors above

songwongtp
songwongtp requested changes Mar 7, 2023
View reviewed changes
@poomthiti poomthiti requested a review from evilpeach March 31, 2023 07:57
@poomthiti poomthiti requested a review from evilpeach April 3, 2023 08:36
evilpeach
evilpeach approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

songwongtp
songwongtp approved these changes Apr 5, 2023
View reviewed changes
@poomthiti poomthiti merged commit a58143d into develop Apr 5, 2023
@poomthiti poomthiti deleted the pages/tx-page branch April 5, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tansawit tansawit tansawit approved these changes

@evilpeach evilpeach evilpeach approved these changes

@songwongtp songwongtp songwongtp approved these changes

@bkioshn bkioshn bkioshn approved these changes

@traviolus traviolus traviolus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@poomthiti @traviolus @tansawit @evilpeach @songwongtp @bkioshn