Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove next-pwa, update next config #185

Merged
merged 3 commits into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug fixes

- [#185](https://github.com/alleslabs/celatone-frontend/pull/185) Fix sentry in next.config.js
- [#183](https://github.com/alleslabs/celatone-frontend/pull/183) Fix build failed because sentry env
- [#175](https://github.com/alleslabs/celatone-frontend/pull/175) Fix css related issue and tag selection input
- [#165](https://github.com/alleslabs/celatone-frontend/pull/165) Fix messages type
Expand Down
32 changes: 11 additions & 21 deletions next.config.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,20 @@
// This file sets a custom webpack configuration to use your Next.js app
// with Sentry.
// https://nextjs.org/docs/api-reference/next.config.js/introduction
// https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/
const { withSentryConfig } = require("@sentry/nextjs");
const withPWA = require("next-pwa")({
dest: "public",
disable:
process.env.NODE_ENV === "development" ||
process.env.NODE_ENV === "preview" ||
process.env.NODE_ENV === "production",
// delete two lines above to enable PWA in production deployment
// add your own icons to public/manifest.json
// to re-generate manifest.json, you can visit https://tomitm.github.io/appmanifest/
});

/** @type {import('next').NextConfig} */
module.exports = withPWA({
const nextConfig = {
swcMinify: true,
reactStrictMode: true,
eslint: {
dirs: ["src"],
},
});
};

module.exports = withSentryConfig(
module.exports,
{ silent: true, authToken: process.env.SENTRY_AUTH_TOKEN },
{ hideSourcemaps: true }
);
const moduleExports = {
...nextConfig,

sentry: {
hideSourceMaps: true,
},
};

module.exports = withSentryConfig(moduleExports);
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"mobx-persist-store": "^1.1.2",
"mobx-react-lite": "^3.4.0",
"next": "^13.0.0",
"next-pwa": "^5.6.0",
"next-seo": "^5.8.0",
"react": "^18.2.0",
"react-ace": "^10.1.0",
Expand Down
Loading