Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): fix native token label formatting #117

Merged
merged 7 commits into from
Jan 26, 2023
Merged

fix(components): fix native token label formatting #117

merged 7 commits into from
Jan 26, 2023

Conversation

tansawit
Copy link
Contributor

@tansawit tansawit commented Jan 23, 2023 •
edited
Loading

Describe your changes

In most places right now, we're assuming that the only native tokens that will be rendered are uTokens (uosmo, uion, etc.). However, for certain chains like Osmosis, certain IBC and other native tokens can also be used as gas fees etc. This PR add support for those cases.

Changes:

  • Unify native token label formatting into one function getTokenLabel
  • Add cases for formatting non "uTokens" (e.g. IBC, tokenfactory module tokens, etc.)
  • switch all instances of formatUDenom to use getTokenLabel

@vercel
Copy link

vercel bot commented Jan 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:37AM (UTC)
osmosis-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:37AM (UTC)
terra-celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:37AM (UTC)
5 Ignored Deployments
Name Status Preview Comments Updated
celatone-custom-chain-temp ⬜️ Ignored (Inspect) Jan 26, 2023 at 3:37AM (UTC)
celatone-frontend ⬜️ Ignored (Inspect) Jan 26, 2023 at 3:37AM (UTC)
celatone-frontend-initial-demo ⬜️ Ignored (Inspect) Jan 26, 2023 at 3:37AM (UTC)
osmosis-celatone-frontend ⬜️ Ignored (Inspect) Jan 26, 2023 at 3:37AM (UTC)
terra-celatone-frontend ⬜️ Ignored (Inspect) Jan 26, 2023 at 3:37AM (UTC)

@evilpeach evilpeach added the bug Something isn't working label Jan 23, 2023
@bkioshn bkioshn requested a review from evilpeach January 23, 2023 08:56
@tansawit tansawit requested a review from evilpeach January 24, 2023 07:27
@poomthiti poomthiti mentioned this pull request Jan 24, 2023
Merged
@evilpeach evilpeach merged commit 33a351f into develop Jan 26, 2023
@evilpeach evilpeach deleted the fix/native-token-label-format branch January 26, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@bkioshn bkioshn bkioshn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tansawit @evilpeach @bkioshn