[CFE-610]: Feature - evm contract assets #1116
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes primarily focus on enhancing the application's support for Ethereum Virtual Machine (EVM) functionality. This includes the introduction of new components for displaying EVM contract details, updates to configuration types, and the addition of hooks for interacting with EVM parameters and contract information. Additionally, several utility functions and validation schemas have been introduced or modified to accommodate these enhancements, contributing to a more robust framework for managing EVM-related data. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant EvmContractDetails
participant EvmService
User->>App: Requests EVM contract details
App->>EvmContractDetails: Fetch contract details
EvmContractDetails->>EvmService: Get contract info
EvmService-->>EvmContractDetails: Return contract data
EvmContractDetails-->>App: Send contract details
App-->>User: Display contract details
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Poafs1
changed the base branch from
develop
to
feature/cfe-613-contract-bytecode
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post
Actionable comments posted: 7
Outside diff range, codebase verification and nitpick comments (2)
src/lib/utils/address.ts (1)
72-79: New Ethereum public key handling added.The addition of Ethereum public key processing is a significant enhancement. The use of
Secp256k1for uncompressing andkeccak256for hashing aligns with Ethereum standards.The code changes are approved.
Consider adding detailed unit tests for this new logic to ensure its correctness and robustness.
src/lib/pages/evm-contract-details/components/EvmContractDetailsOverview.tsx (1)
20-92: New component for EVM contract details introduced.The
EvmContractDetailsOverviewcomponent is well-structured and makes good use of modern React practices. It handles loading states and integrates various smaller components effectively.The code changes are approved.
Ensure that all edge cases and error states are handled appropriately in future iterations.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (35)
- CHANGELOG.md (1 hunks)
- package.json (1 hunks)
- src/config/chain/devChainConfigs.ts (1 hunks)
- src/lib/app-provider/contexts/default.ts (1 hunks)
- src/lib/app-provider/env.ts (1 hunks)
- src/lib/app-provider/hooks/useConfig.ts (1 hunks)
- src/lib/app-provider/hooks/useConvertHexAddress.ts (2 hunks)
- src/lib/app-provider/hooks/useGas.ts (2 hunks)
- src/lib/components/json/TextReadOnly.tsx (1 hunks)
- src/lib/layout/network-menu/NetworkMenuBody.tsx (4 hunks)
- src/lib/layout/network-menu/hooks/useNetworkSelector.ts (3 hunks)
- src/lib/layout/network-menu/index.tsx (2 hunks)
- src/lib/pages/custom-network/types.ts (3 hunks)
- src/lib/pages/evm-contract-details/components/EvmContractDetailsBytecode.tsx (1 hunks)
- src/lib/pages/evm-contract-details/components/EvmContractDetailsOverview.tsx (1 hunks)
- src/lib/pages/evm-contract-details/components/EvmContractDetailsTop.tsx (1 hunks)
- src/lib/pages/evm-contract-details/index.tsx (1 hunks)
- src/lib/pages/evm-contract-details/types.ts (1 hunks)
- src/lib/services/evm/index.ts (1 hunks)
- src/lib/services/evm/lcd.ts (1 hunks)
- src/lib/services/types/evm/codes.ts (1 hunks)
- src/lib/services/types/evm/index.ts (1 hunks)
- src/lib/services/types/evm/params.ts (1 hunks)
- src/lib/services/types/index.ts (1 hunks)
- src/lib/services/types/tx.ts (1 hunks)
- src/lib/stores/chain-config.test.ts (1 hunks)
- src/lib/styles/globals.css (1 hunks)
- src/lib/styles/theme/components/button.ts (1 hunks)
- src/lib/types/chainConfig.ts (2 hunks)
- src/lib/utils/address.ts (2 hunks)
- src/lib/utils/validate.ts (1 hunks)
- src/pages/[network]/evm-contracts/[contractAddress]/[tab].tsx (1 hunks)
- src/pages/[network]/evm-contracts/[contractAddress]/index.tsx (1 hunks)
- src/pages/evm-contracts/[contractAddress]/[tab].tsx (1 hunks)
- src/pages/evm-contracts/[contractAddress]/index.tsx (1 hunks)
Files skipped from review due to trivial changes (8)
- CHANGELOG.md
- src/lib/services/types/evm/index.ts
- src/lib/styles/globals.css
- src/lib/utils/validate.ts
- src/pages/[network]/evm-contracts/[contractAddress]/[tab].tsx
- src/pages/[network]/evm-contracts/[contractAddress]/index.tsx
- src/pages/evm-contracts/[contractAddress]/[tab].tsx
- src/pages/evm-contracts/[contractAddress]/index.tsx
Additional comments not posted (32)
src/lib/services/types/evm/codes.ts (1)
1-8: Well-structured Zod schema and TypeScript type definition.The Zod schema is appropriately defined for the EVM codes by address response, and the TypeScript type is correctly inferred. This setup ensures strong typing and validation, which is crucial for data integrity.
The code changes are approved.
src/lib/services/types/evm/params.ts (1)
1-11: Comprehensive and well-defined Zod schema for EVM parameters.The schema effectively captures various EVM parameters with appropriate data types, ensuring robust validation and strong typing. This setup will facilitate the handling of EVM-related configurations and interactions.
The code changes are approved.
src/lib/services/types/index.ts (1)
5-5: Appropriate integration of the EVM module.The export statement for the
evmmodule is correctly added, enhancing the modularity and accessibility of EVM-related functionalities within the application. This change aligns well with the PR objectives.The code changes are approved.
src/lib/pages/evm-contract-details/types.ts (2)
1-10: Well-structured imports and enum definition.The import of
zfromzodandzHexAddr20fromlib/typesare correctly used for validation purposes. TheTabIndexenum is clearly defined and will help in managing UI components effectively.The code changes are approved.
12-21: Robust validation schema for query parameters.The
zEvmContractDetailsQueryParamsschema is well-defined, ensuring thatcontractAddressis validated properly andtabhas sensible defaults. This setup will help in maintaining strong type safety and default behaviors in the UI.The code changes are approved.
src/lib/app-provider/contexts/default.ts (1)
22-24: Appropriate addition ofevmproperty to configuration.The inclusion of the
evmproperty inDEFAULT_CHAIN_CONFIGis well-implemented, mirroring the structure of existing properties likemoveandpool. This addition enhances the configurability of the system, particularly for EVM functionalities.The code changes are approved.
src/lib/app-provider/hooks/useGas.ts (2)
18-18: Improved error handling for fee tokens.The addition of a check for
fees.fee_tokensbeing undefined or empty is a robust improvement. It ensures that the function gracefully handles cases where fee tokens are not available, thus preventing potential runtime errors.The code changes are approved.
27-27: Clarifying comment for fee token usage.The comment added to explain the use of the first fee token for gas parameters is helpful for future maintainability and understanding of the code. It provides clear context on how gas parameters are derived from the fee tokens.
The code changes are approved.
src/lib/app-provider/hooks/useConvertHexAddress.ts (1)
4-4: Approved: Updated import statement.The addition of
BechAddr20andBechAddr32types aligns with the enhanced type safety requirements of the hook functions.src/lib/pages/evm-contract-details/components/EvmContractDetailsBytecode.tsx (1)
1-40: Approved: New component for EVM contract bytecode details.The implementation uses standard React and Chakra UI patterns effectively. The
StyledCustomTabandTextReadOnlycomponents are appropriately used for displaying the bytecode in a user-friendly manner.src/lib/services/evm/lcd.ts (2)
11-19: Approved: Function for fetching EVM parameters.The use of axios for API requests and zod for parsing and validating the response is correctly implemented.
16-19: Approved: Function for fetching EVM codes by address.The implementation is correct, and the use of zod for response validation ensures data integrity.
src/lib/pages/evm-contract-details/components/EvmContractDetailsTop.tsx (1)
13-49: Review ofEvmContractDetailsTopComponentThe component is well-structured and makes good use of Chakra UI components for styling and layout. The use of custom hooks like
useConvertHexAddressis appropriate for the functionality required. However, consider adding PropTypes or TypeScript interfaces for better type safety and documentation, especially for the props of this component.
- Props Definition: The
EvmContractDetailsTopPropsinterface is well-defined. Ensure that all potential props are covered.- Custom Hook Usage: The usage of
useConvertHexAddressis appropriate. Ensure that error handling is considered in the hook itself since it's not visible here.- UI Composition: The use of
FlexandStackfrom Chakra UI for layout is appropriate and makes the component responsive.- Accessibility: Consider adding
aria-labelsto interactive elements likeCopyLinkfor better accessibility.- Performance: Ensure that the
convertHexWalletAddressfunction is optimized as it's used in rendering, which could impact performance if not handled efficiently.Overall, the component is implemented correctly, but ensure thorough testing, especially for edge cases like long contract addresses or unexpected input types.
The component structure and usage of hooks and UI elements are approved.
src/lib/services/evm/index.ts (3)
17-30: Review ofuseEvmParamsHookThe hook uses
useQueryeffectively to fetch EVM parameters. The configuration options likerefetchOnWindowFocus: falseandretry: falseare appropriate to reduce unnecessary network requests. However, consider the following improvements:
- Error Handling: Add error handling in the query function to manage API errors gracefully.
- Dependency Management: Ensure that
lcdEndpointis stable or memoized to avoid unnecessary re-renders or refetches.- Performance: The
staleTime: Infinitysetting disables automatic refetching, which is suitable if the data doesn't change often. Confirm this assumption with backend developers or data providers.Overall, the hook is implemented correctly but ensure that it's tested thoroughly, especially for error scenarios.
The hook implementation is approved with suggestions for minor improvements.
32-44: Review ofuseEvmCodesByAddressHookThe conditional enabling of the hook based on
isHexWalletAddress(address)is a good practice to avoid unnecessary API calls. However, consider the following improvements:
- Error Handling: Similar to
useEvmParams, add error handling within the query function.- Performance: The retry logic is set to 1, which is reasonable. Ensure that the API can handle these retries without significant performance degradation.
- Conditional Logic: The use of
enabledproperty is appropriate. Ensure thatisHexWalletAddressis thoroughly tested to prevent false negatives or positives.Overall, the hook is well-implemented with considerations for performance and conditional execution.
The hook implementation is approved with suggestions for robust error handling.
46-61: Review ofuseEvmContractInfoSequencerHookThis hook fetches detailed EVM contract information and is well-configured with multiple dependencies to ensure data freshness. Consider the following improvements:
- Error Handling: Implement robust error handling within the query function to manage API errors effectively.
- Dependency Management: The use of multiple dependencies in the query key is appropriate. Ensure that all dependencies are stable or memoized to prevent unnecessary refetches.
- Performance: The
refetchOnWindowFocus: falsesetting is appropriate to reduce network load. Ensure that the backend can handle the load if multiple clients are fetching data simultaneously.Overall, the hook is implemented correctly but ensure thorough testing, especially for cases where dependencies change frequently.
The hook implementation is approved with suggestions for enhanced error handling and dependency management.
src/lib/components/json/TextReadOnly.tsx (1)
18-76: Review ofTextReadOnlyComponentThe
TextReadOnlycomponent is well-implemented using AceEditor to display read-only text. The conditional rendering of the copy button based on thecanCopyprop is a good practice. However, consider the following improvements:
- Props Definition: The
TextReadOnlyPropsinterface is clear. Consider documenting the props for better maintainability.- Accessibility: Ensure that all interactive elements are accessible, including keyboard navigation for the copy button.
- Performance: The use of AceEditor is appropriate, but ensure that the component does not re-render unnecessarily, especially with large texts.
Overall, the component is implemented correctly, but ensure thorough testing, especially for accessibility and performance.
The component structure and usage of AceEditor are approved.
src/lib/layout/network-menu/index.tsx (2)
34-34: Proper integration offilteredDevnetChainsinuseNetworkSelector.The addition of
filteredDevnetChainsis consistent with the PR objectives and enhances the component's functionality by supporting development networks.
78-78: Correct usage offilteredDevnetChainsinNetworkMenuBody.The
filteredDevnetChainsprop is passed correctly to theNetworkMenuBodycomponent. Verify thatNetworkMenuBodyis updated to handle this prop.Run the following script to verify the handling of
filteredDevnetChainsinNetworkMenuBody:Verification successful
Verified:
filteredDevnetChainsis correctly handled inNetworkMenuBody.The
NetworkMenuBodycomponent is properly set up to handle thefilteredDevnetChainsprop, as confirmed by its inclusion in theNetworkMenuBodyPropsinterface and its usage in the component implementation.
NetworkMenuBody.tsx: DefinesfilteredDevnetChainsinNetworkMenuBodyProps.index.tsx: PassesfilteredDevnetChainstoNetworkMenuBody.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the handling of `filteredDevnetChains` in `NetworkMenuBody`. # Test: Search for the `NetworkMenuBody` component definition. Expect: Handling of `filteredDevnetChains`. rg --type typescript -A 10 $'NetworkMenuBody'Length of output: 79
Script:
#!/bin/bash # Description: Verify the handling of `filteredDevnetChains` in `NetworkMenuBody`. # Test: Search for the `NetworkMenuBody` component definition. Expect: Handling of `filteredDevnetChains`. rg --type tsx -A 10 $'NetworkMenuBody'Length of output: 65
Script:
#!/bin/bash # Description: Verify the handling of `filteredDevnetChains` in `NetworkMenuBody`. # Test: Search for the `NetworkMenuBody` component definition. Expect: Handling of `filteredDevnetChains`. rg -A 10 $'NetworkMenuBody'Length of output: 3926
src/config/chain/devChainConfigs.ts (1)
27-29: New EVM configuration added.The addition of the
evmconfiguration with anenabledproperty set tofalseis a prudent way to introduce potential future EVM features without affecting existing functionality.The code changes are approved.
src/lib/app-provider/hooks/useConfig.ts (1)
83-95: Well-implemented new configuration hook for EVM.The
useEvmConfighook is consistent with the existing configuration management hooks and correctly utilizes theuseCelatoneAppanduseBaseConfigfunctions. It should work as intended if theevmfeature is correctly defined in thechainConfig.The code changes are approved.
Run the following script to verify the
evmfeature definition:Verification successful
The
evmfeature is correctly defined in the configuration.The
evmfeature is present in multiple configuration files, confirming its integration within the application's configuration. TheuseEvmConfighook should function as intended. Here are the locations where theevmfeature is defined:
src/config/chain/devChainConfigs.tssrc/lib/stores/chain-config.test.tssrc/lib/pages/custom-network/types.tssrc/lib/app-provider/contexts/default.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `evm` feature definition in the chain configuration. # Test: Search for the `evm` feature definition. Expect: Definitions that match the expected structure. rg --type typescript -A 5 $'evm: {'Length of output: 112
Script:
#!/bin/bash # Description: Verify the `evm` feature definition in the chain configuration. # Test: Search for the `evm` feature definition. Expect: Definitions that match the expected structure. rg --type typescript -A 5 $'evm: \\{'Length of output: 72
Script:
#!/bin/bash # Description: Verify the `evm` feature definition in the chain configuration. # Test: Search for the `evm` feature definition. Expect: Definitions that match the expected structure. rg -A 5 $'evm: \\{'Length of output: 1421
src/lib/layout/network-menu/NetworkMenuBody.tsx (1)
20-20: Proper integration of newfilteredDevnetChainsproperty.The addition of
filteredDevnetChainsis well integrated into theNetworkMenuBodycomponent. The conditional rendering and index calculation are correctly implemented to handle the new Devnet category. Ensure that the property is populated appropriately in the upstream logic.The code changes are approved.
Run the following script to verify the population of
filteredDevnetChains:Also applies to: 32-32, 81-107
src/lib/types/chainConfig.ts (1)
35-44: Well-defined schema for EVM configuration.The
zEvmConfigschema correctly captures the conditions for EVM configurations, allowing for robust validation of EVM-related settings. Ensure that this schema integrates seamlessly with the broaderzApiChainConfig.The code changes are approved.
Run the following script to verify the integration with
zApiChainConfig:Also applies to: 204-204
Verification successful
Integration of
zEvmConfigis correct.The
zEvmConfigis correctly integrated within a larger configuration schema, ensuring seamless validation and usage alongside other configurations likezNftConfigandzPoolConfig. This confirms the robustness of the configuration setup.
- Location:
src/lib/types/chainConfig.tsScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of `zEvmConfig` with `zApiChainConfig`. # Test: Search for the usage of `zEvmConfig` in `zApiChainConfig`. Expect: Correct integration. rg --type typescript -A 5 $'zEvmConfig'Length of output: 73
Script:
#!/bin/bash # Description: Verify the integration of `zEvmConfig` with `zApiChainConfig`. # Test: Search for the usage of `zEvmConfig` in `zApiChainConfig`. Expect: Correct integration. rg --type ts -A 5 $'zEvmConfig'Length of output: 644
package.json (1)
45-45: Approved version update for @alleslabs/shared.The version update from
1.0.0-dev2to1.0.0-dev3is noted. It's crucial to verify that this update integrates well with the rest of the project and does not introduce breaking changes.The change is approved.
Run the following script to check for potential breaking changes or compatibility issues:
src/lib/pages/evm-contract-details/index.tsx (1)
1-11: Review imports and hook usage.The imports and hooks are appropriately used for the functionality of this page. Ensure that all imported modules are used effectively throughout the component.
The import statements and hook usage are appropriate for this context.
src/lib/styles/theme/components/button.ts (1)
164-164: Approved style update for Button component.The addition of the
backgroundproperty to theoutline-whitevariant enhances the visual consistency of the Button component with the overall theme. Ensure that this change is tested across different browsers to check for any visual regressions.The style update is approved.
src/lib/services/types/tx.ts (1)
38-41: Approved: Addition of EVM specific sign mode.The addition of
9999as a literal value for themodeproperty effectively accommodates the new "minievm sign mode". This change enhances the flexibility and capability of the application to handle EVM-specific transactions.The code changes are approved.
Ensure that the usage of
9999is well-documented and understood within the team to avoid confusion about its purpose.src/lib/app-provider/env.ts (1)
141-143: Approved: Expansion of query keys to support EVM.The addition of
EVM_PARAMS_LCD,EVM_CODES_BY_ADDRESS, andEVM_CONTRACT_INFO_SEQUENCERto theCELATONE_QUERY_KEYSenum is a positive step towards enhancing the application's capabilities to interact with EVM-related data.The code changes are approved.
Verify that these new keys are being used appropriately in other parts of the application.
Verification successful
Verification Successful: New EVM Query Keys Are Utilized Properly
The newly added EVM-related keys
EVM_PARAMS_LCD,EVM_CODES_BY_ADDRESS, andEVM_CONTRACT_INFO_SEQUENCERare being used appropriately within the application. They are integrated into thesrc/lib/services/evm/index.tsfile, indicating their active role in querying EVM-related data.
- File:
src/lib/services/evm/index.ts
- Usage:
EVM_PARAMS_LCDis used to fetch EVM parameters.EVM_CODES_BY_ADDRESSis used to retrieve EVM codes by address.EVM_CONTRACT_INFO_SEQUENCERis used to get EVM contract information sequencer.These usages confirm that the keys are effectively incorporated into the application's logic.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of the new EVM-related keys in the application. # Test: Search for the usage of the new keys. Expect: Instances where these keys are used in the application. rg --type typescript -A 5 $'EVM_PARAMS_LCD|EVM_CODES_BY_ADDRESS|EVM_CONTRACT_INFO_SEQUENCER'Length of output: 128
Script:
#!/bin/bash # Description: Verify the usage of the new EVM-related keys in the application. # Test: Search for the usage of the new keys. Expect: Instances where these keys are used in the application. rg -A 5 'EVM_PARAMS_LCD|EVM_CODES_BY_ADDRESS|EVM_CONTRACT_INFO_SEQUENCER'Length of output: 1962
src/lib/pages/custom-network/types.ts (1)
237-237: Approved: Enhanced network configuration to support EVM.The addition of the
evmproperty to the network configuration types allows for a more flexible handling of EVM-specific parameters. This change is crucial for supporting EVM functionalities in custom network settings.The code changes are approved.
Verify that the new
evmconfigurations integrate seamlessly with other parts of the application that handle network settings.Also applies to: 338-346
src/lib/stores/chain-config.test.ts (1)
18-18: Proper integration of theevmproperty.The addition of the
evmproperty within thefeaturesobject ofMOCK_CONFIGis correctly implemented and follows the existing structure for feature toggles.The code changes are approved.
src/lib/layout/network-menu/hooks/useNetworkSelector.ts (2)
23-30: Well-integrated addition offilteredDevnetChains.The integration of
filteredDevnetChainsinto theuseNetworkSelectorhook is correctly implemented, using the existingfilterChainsutility function and maintaining consistency with other network categories.The code changes are approved.
40-40: Correct handling of the total network count includingfilteredDevnetChains.The update to include
filteredDevnetChainsin the total network count is correctly implemented, ensuring accurate navigation and selection behavior within theuseNetworkSelectorhook.The code changes are approved.
Comments failed to post (7)
src/lib/app-provider/hooks/useConvertHexAddress.ts (2)
17-21: Approved with suggestions: Explicit type casting in
convertHexWalletAddress.The explicit casting to
BechAddr20enhances type safety. Consider adding a runtime type check before casting to ensure the conversion is valid.
26-30: Approved with suggestions: Explicit type casting in
convertHexModuleAddress.The explicit casting to
BechAddr32enhances type safety. Consider adding a runtime type check before casting to ensure the conversion is valid.src/lib/services/evm/lcd.ts (1)
21-43: Approved with suggestions: Function for fetching EVM contract info using a sequencer.
The error handling is good, but consider adding more specific error messages or handling potential network errors more gracefully.
src/lib/utils/address.ts (1)
72-79: Consider refactoring to reduce complexity.
The function is becoming complex with multiple conditional branches for different public key types. Consider using a strategy pattern or similar to handle different key types more cleanly.
This could improve readability and maintainability.
src/lib/pages/evm-contract-details/index.tsx (2)
40-140: Ensure proper error handling and state management.
The component
EvmContractDetailsBodyhandles various states and data fetching operations. It's crucial to ensure that error states and loading states are handled appropriately to improve user experience.Consider adding more detailed error messages and possibly retry mechanisms in case of data fetching failures.
if (isEvmCodesByAddressError || !evmCodesByAddressData || is0x(evmCodesByAddressData.code)) { + // Consider adding a retry button or more detailed error information here return <ErrorFetching dataName="evm contract information" />; }Committable suggestion was skipped due to low confidence.
142-164: Validate query parameters and enhance security.
The function
EvmContractDetailsuses query parameters to fetch and display contract details. It's important to validate these parameters thoroughly to prevent security issues such as injection attacks.Enhance the validation of query parameters to ensure they are sanitized and validated against a strict schema.
const validated = zEvmContractDetailsQueryParams.safeParse(router.query); + // Ensure that the validation schema is strict and covers all edge casesCommittable suggestion was skipped due to low confidence.
src/lib/stores/chain-config.test.ts (1)
18-18: Consider adding specific tests for the
evmproperty.While the existing tests cover the general functionality of the
MOCK_CONFIG, adding specific tests to verify the behavior of theevmproperty when enabled could enhance the robustness of the test suite.Would you like me to help draft some test cases or open a GitHub issue to track this enhancement?
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
Tests