Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(components): remove margin bottom and padding bottom from module #1100

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Fix(components): remove margin bottom and padding bottom from module #1100

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3151f61
fix(components): remove margin button and padding button from module …
Poafs1 Aug 21, 2024
7682e49
docs: update changelog
Poafs1 Aug 21, 2024
6bd6b8f
Merge branch 'develop' into fix/account-modules-tab
songwongtp Aug 22, 2024
0c94173
fix: changelog
songwongtp Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Bug fixes

- [#1100](https://github.com/alleslabs/celatone-frontend/pull/1100) Fix account modules spacing
- [#1091](https://github.com/alleslabs/celatone-frontend/pull/1091) Fix typo function name
- [#1089](https://github.com/alleslabs/celatone-frontend/pull/1089) Fix document links for code detail
- [#1075](https://github.com/alleslabs/celatone-frontend/pull/1075) Fix custom minitia minor change
Expand Down
3 changes: 1 addition & 2 deletions src/lib/pages/account-details/components/modules/ModuleLists.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const ModuleLists = ({
const [keyword, setKeyword] = useState("");
const isMobile = useMobile();
const isMobileOverview = isMobile && !!onViewMore;

return (
<Box mt={{ base: 4, md: 8 }}>
{isMobileOverview ? (
Expand All @@ -46,8 +47,6 @@ export const ModuleLists = ({
direction="column"
borderBottom={modules?.length ? "1px solid" : "0px"}
borderBottomColor="gray.700"
mb={modules?.length ?? 12}
pb={modules?.length ?? 6}
>
{!onViewMore && (
<InputWithIcon
Expand Down
Loading