Skip to content

Commit

Permalink
Merge pull request #339 from alleslabs/chore/update-routes
Browse files Browse the repository at this point in the history
Update route scheme to plural form
  • Loading branch information
evilpeach authored May 18, 2023
2 parents ae56164 + 5c8d6e6 commit 9b6d005
Show file tree
Hide file tree
Showing 58 changed files with 99 additions and 55 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Improvements

- [#339](https://github.com/alleslabs/celatone-frontend/pull/339) Update all routes to plural form, and patch all codes
- [#334](https://github.com/alleslabs/celatone-frontend/pull/334) Change `osmo-test-4` to `osmo-test-5`, fix tx service when accountId is undefined
- [#311](https://github.com/alleslabs/celatone-frontend/pull/311) Refine css styling
- [#328](https://github.com/alleslabs/celatone-frontend/pull/328) Add proposal and pool page in sidebar navigation
Expand Down
42 changes: 42 additions & 0 deletions next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,48 @@ const nextConfig = {
},
];
},
async redirects() {
const routes = [
"account",
"tx",
"block",
"code",
"contract",
"proposal",
"project",
"contract-list",
"past-tx",
"my-code",
];

return routes.reduce((acc, route) => {
acc.push({
source: `/:network/${route}/:id`,
destination: `/:network/${route}s/:id`,
permanent: false,
});

acc.push({
source: `/${route}/:id`,
destination: `/${route}s/:id`,
permanent: false,
});

acc.push({
source: `/:network/${route}`,
destination: `/:network/${route}s`,
permanent: false,
});

acc.push({
source: `/${route}`,
destination: `/${route}s`,
permanent: false,
});

return acc;
}, []);
},
};

const moduleExports = {
Expand Down
10 changes: 5 additions & 5 deletions src/lib/components/ExplorerLink.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@ const getNavigationUrl = (
let url = "";
switch (type) {
case "tx_hash":
url = "/tx";
url = "/txs";
break;
case "contract_address":
url = "/contract";
url = "/contracts";
break;
case "user_address":
url = "/account";
url = "/accounts";
break;
case "validator_address":
url = getExplorerValidatorUrl(currentChainName);
break;
case "code_id":
url = "/code";
url = "/codes";
break;
case "block_height":
url = "/block";
url = "/blocks";
break;
case "proposal_id":
url = getExplorerProposalUrl(currentChainName);
Expand Down
4 changes: 3 additions & 1 deletion src/lib/components/StickySidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ export const StickySidebar = ({
color: "lilac.light",
bgColor: "lilac.background",
}}
onClick={() => navigate({ pathname: "/proposal/store-code" })}
onClick={() =>
navigate({ pathname: "/proposals/store-code" })
}
>
<Text variant="body3" color="inherit" fontWeight={700}>
Submit Proposal To Store Code
Expand Down
7 changes: 3 additions & 4 deletions src/lib/components/button/NewProposalButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const NewProposalButton = () => {
icon={<CustomIcon name="code" color="pebble.600" />}
onClick={() => {
navigate({
pathname: "/proposal/store-code",
pathname: "/proposals/store-code",
});
}}
>
Expand All @@ -33,9 +33,8 @@ export const NewProposalButton = () => {
{/* <MenuItem
icon={<CustomIcon name="contract-address" color="pebble.600"/>}
onClick={() => {
// TODO - Change navigation path
navigate({
pathname: "/proposal-instantiate",
pathname: "/proposals/instantiate",
});
}}
>
Expand All @@ -50,7 +49,7 @@ export const NewProposalButton = () => {
icon={<CustomIcon name="admin" color="pebble.600" />}
onClick={() => {
navigate({
pathname: "/proposal/whitelist",
pathname: "/proposals/whitelist",
});
}}
>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/modal/list/EditListName.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ export function EditListNameModal({
<ActionModal
title="Edit list name"
icon="add-new"
trigger={<MenuItem {...menuItemProps} />}
trigger={<MenuItem {...menuItemProps} as="button" />}
mainBtnTitle="Save"
mainAction={() => {
handleSave();
if (reroute)
navigate({
pathname: "/contract-list/[slug]",
pathname: "/contract-lists/[slug]",
query: { slug: formatSlugName(listName) },
replace: true,
});
Expand Down
6 changes: 3 additions & 3 deletions src/lib/components/modal/list/RemoveList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export function RemoveListModal({ list, menuItemProps }: RemoveListModalProps) {
const handleRemove = () => {
AmpTrack(AmpEvent.LIST_REMOVE);
removeList(userKey, list.value);
navigate({ pathname: "/contract-list" });
// TODO: show toast after removed and redirect to /contract-list
navigate({ pathname: "/contract-lists" });
// TODO: show toast after removed and redirect to /contract-lists
setTimeout(() => {
toast({
title: `Removed ${shortenName(list.label)}`,
Expand All @@ -43,7 +43,7 @@ export function RemoveListModal({ list, menuItemProps }: RemoveListModalProps) {
title={`Remove ${shortenName(list.label)}?`}
icon="delete"
iconColor="error.light"
trigger={<MenuItem {...menuItemProps} />}
trigger={<MenuItem {...menuItemProps} as="button" />}
mainBtnTitle="Yes, Remove list"
mainAction={handleRemove}
otherBtnTitle="No, Keep It"
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/tx/modal/ButtonSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const ButtonSection = ({
<Button
variant="ghost-lilac"
onClick={() => {
navigate({ pathname: "/codes" });
navigate({ pathname: "/my-codes" });
onClose?.();
}}
>
Expand Down Expand Up @@ -99,7 +99,7 @@ export const ButtonSection = ({
<Button
variant="primary"
onClick={() =>
navigate({ pathname: `/contract/${router.query.contract}` })
navigate({ pathname: `/contracts/${router.query.contract}` })
}
>
View Contract Details
Expand Down
4 changes: 2 additions & 2 deletions src/lib/hooks/useIsCurrentPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export const useIsCurrentPage = () => {
case "/":
return pathName === `${networkPath}` || pathName === "/";
// handle contract list page and public project page
case "/contract-list":
case "/public-project":
case "/contract-lists":
case "/projects":
return pathName === `${networkPath}${slug}`;
// handle page with query param
default:
Expand Down
2 changes: 1 addition & 1 deletion src/lib/hooks/useOpenTxTab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const useOpenTxTab = (type: "lcd" | "tx-page") => {
? `${CELATONE_API_ENDPOINT}/txs/${getChainApiPath(
currentChainName
)}/${chainId}`
: `/${getNetworkByChainName(currentChainName)}/tx`;
: `/${getNetworkByChainName(currentChainName)}/txs`;

return useCallback(
(txHash: Option<string>) => {
Expand Down
10 changes: 5 additions & 5 deletions src/lib/layout/Searchbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ interface ResultItemProps {
const getRoute = (type: SearchResultType) => {
switch (type) {
case "Code ID":
return "/code";
return "/codes";
case "Contract Address":
return "/contract";
return "/contracts";
case "Wallet Address":
return "/account";
return "/accounts";
case "Transaction Hash":
return "/tx";
return "/txs";
case "Block":
return "/block";
return "/blocks";
default:
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layout/SubHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const SubHeader = () => {

const activeColor = "violet.light";

const myPageSlug = `/account/${address}`;
const myPageSlug = `/accounts/${address}`;

return (
<Flex px={6} alignItems="center" h="full" justifyContent="space-between">
Expand Down
16 changes: 8 additions & 8 deletions src/lib/layout/navbar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,21 @@ const Navbar = observer(({ isExpand, setIsExpand }: NavbarProps) => {
{
category: "Codes",
submenu: [
{ name: "My Codes", slug: "/codes", icon: "code" },
{ name: "Recent Codes", slug: "/recent-codes", icon: "website" },
{ name: "My Codes", slug: "/my-codes", icon: "code" },
{ name: "Recent Codes", slug: "/codes", icon: "website" },
],
},
{
category: "Contracts",
submenu: [
{
name: INSTANTIATED_LIST_NAME,
slug: `/contract-list/${formatSlugName(INSTANTIATED_LIST_NAME)}`,
slug: `/contract-lists/${formatSlugName(INSTANTIATED_LIST_NAME)}`,
icon: getListIcon(INSTANTIATED_LIST_NAME),
},
{
name: SAVED_LIST_NAME,
slug: `/contract-list/${formatSlugName(SAVED_LIST_NAME)}`,
slug: `/contract-lists/${formatSlugName(SAVED_LIST_NAME)}`,
icon: getListIcon(SAVED_LIST_NAME),
},
...getContractLists()
Expand All @@ -96,12 +96,12 @@ const Navbar = observer(({ isExpand, setIsExpand }: NavbarProps) => {
.slice(0, 3)
.map((list) => ({
name: list.name,
slug: `/contract-list/${list.slug}`,
slug: `/contract-lists/${list.slug}`,
icon: getListIcon(list.name),
})),
{
name: "View All Lists",
slug: "/contract-list",
slug: "/contract-lists",
icon: "more",
},
],
Expand All @@ -114,12 +114,12 @@ const Navbar = observer(({ isExpand, setIsExpand }: NavbarProps) => {
submenu: [
...getSavedPublicProjects().map((list) => ({
name: list.name,
slug: `/public-project/${list.slug}`,
slug: `/projects/${list.slug}`,
logo: list.logo,
})),
{
name: "View All Projects",
slug: "/public-project",
slug: "/projects",
icon: "public-project",
},
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const AdminContractsTable = ({
const navigate = useInternalNavigate();
const onRowSelect = (contract: ContractAddr) =>
navigate({
pathname: "/contract/[contract]",
pathname: "/contracts/[contract]",
query: { contract },
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const InstantiatedContractsTable = ({
const navigate = useInternalNavigate();
const onRowSelect = (contract: ContractAddr) =>
navigate({
pathname: "/contract/[contract]",
pathname: "/contracts/[contract]",
query: { contract },
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const StoredCodesTable = ({
const navigate = useInternalNavigate();
const onRowSelect = (codeId: number) =>
navigate({
pathname: "/code/[codeId]",
pathname: "/codes/[codeId]",
query: { codeId },
});

Expand Down
4 changes: 2 additions & 2 deletions src/lib/pages/block-details/components/BlockDetailsTop.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ export const BlockDetailsTop = ({ blockData }: BlockDetailsTopProps) => {
</Flex>
<Flex gap={2}>
{!disablePrevious && (
<AppLink href={`/block/${block - 1}`}>
<AppLink href={`/blocks/${block - 1}`}>
<StyledIconButton
icon={<CustomIcon name="chevron-left" />}
variant="ghost-gray"
/>
</AppLink>
)}
<AppLink href={`/block/${block + 1}`}>
<AppLink href={`/blocks/${block + 1}`}>
<StyledIconButton
icon={<CustomIcon name="chevron-right" />}
variant="ghost-gray"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const CodeContractsTable = observer(
const navigate = useInternalNavigate();
const onRowSelect = (contract: ContractAddr) =>
navigate({
pathname: "/contract/[contract]",
pathname: "/contracts/[contract]",
query: { contract },
});

Expand Down
2 changes: 1 addition & 1 deletion src/lib/pages/codes/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const Codes = observer(() => {
const navigate = useInternalNavigate();
const onRowSelect = (codeId: number) =>
navigate({
pathname: "/code/[codeId]",
pathname: "/codes/[codeId]",
query: { codeId },
});

Expand Down
2 changes: 1 addition & 1 deletion src/lib/pages/contract-list/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const AllContractListsPage = observer(() => {
const contractLists = [useInstantiatedMockInfoByMe(), ...getContractLists()];

const handleListSelect = (slug: string) => {
navigate({ pathname: "/contract-list/[slug]", query: { slug } });
navigate({ pathname: "/contract-lists/[slug]", query: { slug } });
};

useEffect(() => {
Expand Down
6 changes: 3 additions & 3 deletions src/lib/pages/contract-list/slug.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,15 @@ const ContractsByList = observer(() => {

const onContractSelect = (contract: ContractAddr) =>
navigate({
pathname: "/contract/[contract]",
pathname: "/contracts/[contract]",
query: { contract },
});

useEffect(() => {
// TODO: find a better approach?
const timeoutId = setTimeout(() => {
if (isHydrated && contractListInfo === undefined)
navigate({ pathname: "/contract-list" });
navigate({ pathname: "/contract-lists" });
}, 100);
return () => clearTimeout(timeoutId);
}, [contractListInfo, isHydrated, navigate]);
Expand Down Expand Up @@ -91,7 +91,7 @@ const ContractsByList = observer(() => {
_hover={{ opacity: 0.8 }}
transition="all 0.25s ease-in-out"
>
<AppLink color="text.dark" href="/contract-list">
<AppLink color="text.dark" href="/contract-lists">
Contract Lists
</AppLink>
</BreadcrumbItem>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/pages/instantiate/completed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const Completed = ({ txInfo }: CompletedProps) => {
w="full"
variant="outline-gray"
onClick={() =>
navigate({ pathname: `/contract/${txInfo.contractAddress}` })
navigate({ pathname: `/contracts/${txInfo.contractAddress}` })
}
>
View Contract
Expand Down
Loading

1 comment on commit 9b6d005

@vercel
Copy link

@vercel vercel bot commented on 9b6d005 May 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.