fix: set total data

alleslabs · Apr 10, 2024 · 3ebf1f9 · 3ebf1f9
1 parent 0ce1da4
commit 3ebf1f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/...es/proposal-details/components/vote-details/voting-period/validator-votes-table/index.tsx b/...es/proposal-details/components/vote-details/voting-period/validator-votes-table/index.tsx
@@ -1,5 +1,5 @@
 import { Button, Flex, Grid, GridItem, TableContainer } from "@chakra-ui/react";
-import { useEffect, useMemo, useState } from "react";
+import { useMemo, useState } from "react";
 import type { ChangeEvent } from "react";
 
 import { useMobile } from "lib/app-provider";
@@ -128,14 +128,10 @@ export const ValidatorVotesTable = ({
     pageSize,
     offset,
     answerFilter,
-    debouncedSearch
+    debouncedSearch,
+    { onSuccess: ({ total }) => setTotalData(total) }
   );
 
-  // update total data because we do filter and search on frontend side
-  useEffect(() => {
-    setTotalData(data?.total ?? 0);
-  }, [data, setTotalData]);
-
   const isSearching =
     debouncedSearch !== "" || answerFilter !== ProposalVoteType.ALL;
 

diff --git a/src/lib/services/proposalService.ts b/src/lib/services/proposalService.ts
@@ -45,6 +45,7 @@ import type {
   ProposalAnswerCountsResponse,
   ProposalDataResponse,
   ProposalsResponse,
+  ProposalValidatorVotesResponse,
   ProposalVotesResponse,
   RelatedProposalsResponse,
   UploadAccess,
@@ -384,7 +385,11 @@ export const useProposalValidatorVotes = (
   limit: number,
   offset: number,
   answer: ProposalVoteType,
-  search: string
+  search: string,
+  options: Pick<
+    UseQueryOptions<ProposalValidatorVotesResponse>,
+    "onSuccess"
+  > = {}
 ) => {
   const endpoint = useBaseApiRoute("proposals");
 
@@ -400,7 +405,7 @@ export const useProposalValidatorVotes = (
     ],
     async () =>
       getProposalValidatorVotes(endpoint, id, limit, offset, answer, search),
-    { retry: 1, refetchOnWindowFocus: false }
+    { retry: 1, refetchOnWindowFocus: false, ...options }
   );
 };