Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_self attribute to Attendee instead of omitting #600

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

joelhawksley
Copy link
Contributor

In support of home-assistant/core#128900 (comment), this PR exposes the original value of self as isSelf instead of omitting it.

I also updated the README to reference the pip3 install target correctly.

gcal_sync/model.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.23%. Comparing base (d367b9b) to head (f294e47).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   97.23%   97.23%           
=======================================
  Files           9        9           
  Lines         975      977    +2     
=======================================
+ Hits          948      950    +2     
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@allenporter allenporter merged commit b934e6e into allenporter:main Oct 22, 2024
3 checks passed
@allenporter allenporter changed the title Add isSelf attribute to model instead of omitting Add is_self attribute to Attendee instead of omitting Oct 22, 2024
@joelhawksley joelhawksley deleted the include-self branch October 28, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants