Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ical for timespan and iter utils #124

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Switch to ical for timespan and iter utils #124

merged 2 commits into from
Oct 24, 2022

Conversation

allenporter
Copy link
Owner

Use the ical library for the Timespan class as well as the shared iterators for recurring events. The iterators have a large performance win, and the remaining Timespan will be switched in a followup PR.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #124 (107be3e) into main (b6d144b) will increase coverage by 0.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   96.21%   96.63%   +0.41%     
==========================================
  Files          10        8       -2     
  Lines         846      743     -103     
==========================================
- Hits          814      718      -96     
+ Misses         32       25       -7     
Impacted Files Coverage Δ
gcal_sync/model.py 95.23% <100.00%> (ø)
gcal_sync/timeline.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@allenporter allenporter merged commit b9af06f into main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants