Add deep-merge of values, and allow empty values file

[Lingkar]

Allow empty YAML values files.
Perform a deep merge instead of shallow, for better helm values patching.

(I was unable to locally run the tests, would like to check via the pipeline)

[allenporter]

Hello, appreciate the contribution!

I'd like there to be tests reproducing the problem you've run into here. Can you tell me more about why you were unable to run the tests?

[Lingkar]

@allenporter Seems like the issue was related to missing system dependency kyverno.
I will add some issue specific tests, will notify you when ready.

[Lingkar]

@allenporter I have updated the values tests to include an empty values and a patch values config.
Please let me know if I am missing anything else!

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (3739b3c) to head (eb82ea9).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   93.50%   93.53%   +0.02%     
==========================================
  Files          20       20              
  Lines        2294     2304      +10     
==========================================
+ Hits         2145     2155      +10     
  Misses        149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[allenporter]

Looks great, though I have some minor nits. Also there are lint errors so you'll want to check those. Running run the pre-commit before committing can help catch those.

If the yaml lint doesn't like this and it can't be tested that way easily, you can also use test_values.py since it has some existing tests for this function.

[Lingkar]

@allenporter Thanks for the pre-commit tip! Might be a good idea to update the CONTRIBUTING.md with the system dependency kyverno and the usage of pre-commit?

I have processed the feedback in the PR.
When running pre-commit run --all-files I got some additional files which got updated, I left those out of my commits as unsure if I am supposed to run the pre-commit tool on all-files or just on the changed files in my PR.

[allenporter]

@allenporter Thanks for the pre-commit tip! Might be a good idea to update the CONTRIBUTING.md with the system dependency kyverno and the usage of pre-commit?

As for the pre-commit, yes, good idea, feel free to send a change to update it.
I think I may want to just drop kyverno support so we can leave that out and i'll remove it separatly. Thanks for this suggestion.

I have processed the feedback in the PR. When running pre-commit run --all-files I got some additional files which got updated, I left those out of my commits as unsure if I am supposed to run the pre-commit tool on all-files or just on the changed files in my PR.

Let's stick with just the files in this PR.

[allenporter]

Thanks for the contribution @Lingkar 💯

[allenporter]

I've released this as 6.1.0 and it's causing some HelmReleases to break https://github.com/onedr0p/home-ops/actions/runs/12473136322/job/34813129881

[allenporter]

It appears like the original values are getting dropped https://github.com/onedr0p/home-ops/blob/aa26601e17589c8f4fc88d6a68503d53c9943c25/kubernetes/main/apps/kube-system/cilium/app/helmrelease.yaml#L30