Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method of keeping a player roster #41

Closed
allejo opened this issue Sep 22, 2016 · 0 comments
Closed

Change method of keeping a player roster #41

allejo opened this issue Sep 22, 2016 · 0 comments
Assignees
Milestone

Comments

@allejo
Copy link
Owner

allejo commented Sep 22, 2016

The recorded roster for FMs are far from reliable, if a person leaves a few seconds before the match ends then the report will fail. If I'm not mistaken, this probably has to do with the constant team verification checks that aren't disabled for FMs.

@allejo allejo added the bug label Sep 22, 2016
@allejo allejo added this to the v1.1.4 milestone Sep 22, 2016
@allejo allejo self-assigned this Sep 22, 2016
allejo added a commit that referenced this issue Oct 1, 2016
- Addresses #41
- Team verification has been removed since it probably did more harm than good. League Overseer shouldn't try to be smart and guess teams inaccurately, let BZiON do it
- Team affiliation is now calculated based on their playing time. For example, in an official match a player will play on the correct team the longest time (I hope) so it'll report their loyalty as that team. For fun matches, the team the player is on the longest will be their affiliation so if they switch teams in the match, the team they played on the longest will be their team
- For fun matches, it is required that players play at LEAST 2/7 of the match in order to be considered a part of the match
- For official matches, it is required that players play at LEAST 5 minutes of the match in order to be considered a part of the match
- Players who are idle in the last 2 minutes of a match will not be reported as part of the match. This is hopes that inactive players who idle for an entire match do not cause issues with the reports
allejo referenced this issue Oct 1, 2016
Thanks a lot to @asinck for the help, feedback, and sanity checks

Instead of disqualifying players for being idle in the last 2 minutes of the
match, we'll start keeping track of the total estimated amount of idle time
throughout the entire match. 90% of this idle time will be substracted from the
total playing times of players for checking the minimum amount of playing time
during a match
@allejo allejo changed the title FM Roster Issues Change method of keeping a player roster Oct 1, 2016
@allejo allejo closed this as completed Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant