-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update URLs for web links #561
Merged
alixlahuec
merged 8 commits into
main
from
feature/rm-549-bug-zotero-web-library-item-urls-are-not-working-anymore
Feb 10, 2024
Merged
fix: update URLs for web links #561
alixlahuec
merged 8 commits into
main
from
feature/rm-549-bug-zotero-web-library-item-urls-are-not-working-anymore
Feb 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixlahuec
changed the title
fix(links): update URLs of web links
fix: update URLs for web links
Feb 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 85.74% 85.70% -0.03%
==========================================
Files 162 162
Lines 4998 5000 +2
Branches 1308 1310 +2
==========================================
Hits 4285 4285
- Misses 711 713 +2
Partials 2 2
|
alixlahuec
deleted the
feature/rm-549-bug-zotero-web-library-item-urls-are-not-working-anymore
branch
February 10, 2024 21:55
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update how web links are generated, since Zotero has changed their internals. From manual checks, URLs obtained through navigation look like:
https://www.zotero.org/:username/items/:itemKey/library
https://www.zotero.org/groups/:groupId/:groupName/items/:itemKey/library
Some other patterns also work:
https://www.zotero.org/:username/items/:itemKey
(aka without /library suffix)https://www.zotero.org/groups/:groupId/:groupName/items/:itemKey
(aka without /library suffix)https://www.zotero.org/groups/:groupId/items/:itemKey/library
(aka without group name; it'll redirect to the equivalent with the group name, though)https://www.zotero.org/groups/:groupId/items/:itemKey
This PR updates the user pattern so that links work again (= username instead of
users/:userId
), and updates the group pattern so that it matches the eventual URL (=groups/:groupId/:groupName
instead ofgroups/:groupId
) even though it's not functionally broken otherwise.Fixes #496
Validation
✅ User library links are correct
✅ Group library links are correct