Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect items are shown in DNP menus #396

Conversation

alixlahuec
Copy link
Owner

@alixlahuec alixlahuec commented Sep 9, 2023

Description

Fix a regression introduced in the switch to Typescript, where date parsing for DNP menus is off by 1 month. Root cause is the difference between new Date(2022, 12, 1) (Jan 1st, 2023) and new Date([2022, 12, 1]) (Dec 1st, 2022). Previous versions used the latter, as it's a 1-index, but it's invalid TS so the extension now uses the former - I missed updating the date extraction logic in the DNPMenuFactory to account for the change.

Validation

No items on June 6th, 2023
image

3 items on May 6th, 2023
image
image
image

@linear
Copy link

linear bot commented Sep 9, 2023

RM-401 [BUG] The recent added items showed in the daily notes are not correct

zoteroRoam version : 0.7.18/Latest

What happened ?
The recent added items showed in the daily notes are not correct.

I found this issue in recent one week. I don't know if it comes from Zotero or zoteroRoam extension (possibly from the extension given the data in the Dashboard is correct).

You can see from the second screenshot, even though it showed some items they were not corresponding to that added date and time.
I tried with the previous version of zoteroRoam like v0.7.17 but it kept the same. Very annoying...

System :
[ x ] Windows
[ x ] Mac

Context :
[ x ] Browser, specify : Chrome
[ x ] Roam desktop app
[ x ] Roam mobile PWA

Screenshots

Additional information
It seemed to happen after I upgraded the Roam and extension in recent one week. It worked without any issues before this upgrade.

#357

@alixlahuec alixlahuec merged commit ee168ea into beta Sep 9, 2023
@alixlahuec alixlahuec deleted the feature/rm-401-bug-the-recent-added-items-showed-in-the-daily-notes-are-not branch September 9, 2023 16:36
@github-actions github-actions bot mentioned this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant