fix: incorrect items are shown in DNP menus #396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression introduced in the switch to Typescript, where date parsing for DNP menus is off by 1 month. Root cause is the difference between
new Date(2022, 12, 1)
(Jan 1st, 2023) andnew Date([2022, 12, 1])
(Dec 1st, 2022). Previous versions used the latter, as it's a 1-index, but it's invalid TS so the extension now uses the former - I missed updating the date extraction logic in theDNPMenuFactory
to account for the change.Validation
No items on June 6th, 2023
3 items on May 6th, 2023