-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable importing specific notes #135
Merged
alixlahuec
merged 16 commits into
beta
from
feature/rm-36-enable-import-of-selected-notes-vs-all
Dec 11, 2022
Merged
feat: enable importing specific notes #135
alixlahuec
merged 16 commits into
beta
from
feature/rm-36-enable-import-of-selected-notes-vs-all
Dec 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM-36 Enable import of selected notes vs all notes
|
Codecov Report
@@ Coverage Diff @@
## beta #135 +/- ##
==========================================
+ Coverage 86.87% 86.90% +0.03%
==========================================
Files 122 125 +3
Lines 4081 4165 +84
Branches 1168 1186 +18
==========================================
+ Hits 3545 3619 +74
- Misses 522 532 +10
Partials 14 14
|
alixlahuec
deleted the
feature/rm-36-enable-import-of-selected-notes-vs-all
branch
December 11, 2022 00:56
This was referenced Dec 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the behavior for the
Import notes
button in theCitekeyMenu
component, to open a dialog instead of directly triggering import. The modal enables the user to select which annotations/notes they want to import, with some convenience selectors (Select/Unselect all ; Select/Unselect all from a given day).title
The PR also updates codecov's
patch
config, to tolerate coverage decreases below < 5%.Validation
✅ Storybook testing, with interactions
✅ Dev build