No Data animation showing in case of empty data from API response #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezaeiii
reviewed
Jun 10, 2024
| @@ -85,6 +86,9 @@ fun <T : TMDbItem> Search( | |||
| @StringRes resourceId: Int, | |||
| modifier: Modifier = Modifier | |||
| ) { | |||
|
|
|||
alirezaeiii
reviewed
Jun 10, 2024
| @@ -98,6 +102,7 @@ fun <T : TMDbItem> Search( | |||
| ) { | |||
| AnimatedSearch() | |||
| } | |||
|
|
|||
alirezaeiii
requested changes
Jun 10, 2024
alirezaeiii
reviewed
Jun 10, 2024
| @@ -58,8 +59,10 @@ object Deps { | |||
| const val composeUiTooling = "androidx.compose.ui:ui-tooling:${Versions.compose}" | |||
| const val composeUiToolingPreview = "androidx.compose.ui:ui-tooling-preview:${Versions.compose}" | |||
| const val navigationCompose = "androidx.navigation:navigation-compose:${Versions.nav_version}" | |||
| const val composeConstraintLayout = "androidx.constraintlayout:constraintlayout-compose:${Versions.constraint_layout}" | |||
| const val iconExtended = "androidx.compose.material:material-icons-extended:${Versions.icon_extended}" | |||
| const val composeConstraintLayout = | |||
There was a problem hiding this comment.
Is there any reason you add a space here?
alirezaeiii
reviewed
Jun 10, 2024
| @@ -75,8 +78,10 @@ object Deps { | |||
|
|
|||
| // Core | |||
| const val lifecycleLiveData = "androidx.lifecycle:lifecycle-livedata-ktx:${Versions.lifecycle}" | |||
| const val lifecycleViewModel = "androidx.lifecycle:lifecycle-viewmodel-ktx:${Versions.lifecycle}" | |||
| const val lifecycleSavedstate = "androidx.lifecycle:lifecycle-viewmodel-savedstate:${Versions.lifecycle}" | |||
| const val lifecycleViewModel = | |||
|
@alirezaeiii |
alirezaeiii
approved these changes
Jun 11, 2024
Approved, Thanks again, Feel free to share any other new idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Data animation showing when there is empty data coming from API response.
Screen.Recording.2024-06-10.at.6.09.18.PM.mov