Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alire.Crate_Configuration: add built-in values for host OS, Arch and Distro #961

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

Fabien-Chouteau
Copy link
Member

No description provided.

@Fabien-Chouteau Fabien-Chouteau requested a review from mosteo March 30, 2022 16:43
@Fabien-Chouteau Fabien-Chouteau force-pushed the crate_config_host_os_arch_distro branch 3 times, most recently from bb2cbfe to b226fa3 Compare March 30, 2022 18:07
@Fabien-Chouteau
Copy link
Member Author

stderr: Command ["pacman", "-V"] exited with code-1 and output:

Msys2's pacman is being annoying. This is a good time to investigate how to improve that part of Alire...

@Fabien-Chouteau Fabien-Chouteau force-pushed the crate_config_host_os_arch_distro branch from b226fa3 to e48716a Compare March 30, 2022 18:21
Copy link
Member

@mosteo mosteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, once tests pass.

@Fabien-Chouteau Fabien-Chouteau force-pushed the crate_config_host_os_arch_distro branch from 89ec5ea to af754c7 Compare April 4, 2022 16:28
…Distro

This will be very useful for platform specific code.
The Ada/GPR constant names, package names, and enum values are forced to mixed case.
The C constant names are forced to upper case.
Msys2 install in Alire.Platforms.Init added elaboration issue for code using (e.g.) Current.Operating_System in elaboration.
@Fabien-Chouteau Fabien-Chouteau force-pushed the crate_config_host_os_arch_distro branch from af754c7 to 995b5c9 Compare April 4, 2022 16:49
@Fabien-Chouteau
Copy link
Member Author

@mosteo fixed now. I had to change the Windows Platforms code again 🤷‍♂️

@mosteo
Copy link
Member

mosteo commented Apr 4, 2022

I see, thanks Fabien.

@mosteo mosteo merged commit 9b300fd into master Apr 4, 2022
@mosteo mosteo deleted the crate_config_host_os_arch_distro branch April 4, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants