New property for detected host architecture #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
feat/architecture
branch
from
30f574b to
db5f431
Compare
This will allow indexing the proper binaries for different host architectures.
mosteo
force-pushed
the
feat/architecture
branch
from
db5f431 to
4c322d0
Compare
Fabien-Chouteau
requested changes
Mar 9, 2022
mosteo
force-pushed
the
feat/architecture
branch
from
fced620 to
40bfb14
Compare
Fabien-Chouteau
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow indexing the proper binaries for different host architectures.
Since using this property will require changing the index version, for now I would just leave the PR unmerged and merge it for the next major release.There are other backwards-incompatible changes merged, but that's no problem because the stable index is forward-compatible.
Fixes #849