Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test duration measurement #1848

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Feb 13, 2025

Enable time tracking in e3 testsuite

@mosteo
Copy link
Member Author

mosteo commented Feb 13, 2025

@Seb-MCaw I'm seeing this test taking almost 3 minutes, do you think this is expected? I see it's a long one so it could be normal.

Running it locally I had to kill it after ~10 minutes, so something seems suspicious.

@Seb-MCaw
Copy link
Contributor

Yes it's always been rather slow, sorry.

I've never seen it take as long as 10mins on Linux, so that would indeed be suspicious (my local machine runs the whole master branch testsuite in less than 2mins). It's less surprising if you're on MacOS, where the compiler (which the test is calling out to repeatedly) seems a lot slower in general.

Let me know if this is an issue, as I'm sure it could easily be improved; perhaps calls to gprbuild could be intercepted by a MockCommand.

@mosteo
Copy link
Member Author

mosteo commented Feb 13, 2025

Nevermind my time, that was an unrelated issue. That test takes a bit less than 2 mins in my machine, so it seems everything is as expected. I too had noticed that macOS, particularly x64, is much slower. Thanks!

@mosteo mosteo marked this pull request as ready for review February 13, 2025 13:58
@mosteo mosteo merged commit 0ec4e6a into alire-project:master Feb 13, 2025
31 checks passed
@mosteo mosteo deleted the feat/test-timing branch February 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants