-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use the cache location for shared releases #1349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be worth adding a test.
I thought about it, but all of our tests are running with custom config to avoid getting contaminated by the user config. So in a way it's being tested, but the default isn't. I can't think an easy way of running a test with default environment short of using something like chroot... Do you have any ideas? |
I forgot about the custom config for the testsuite. I don't have a solution to offer... |
I've got a solution for testing with default config but that will be in a separate PR as it's not trivial. In this one I've added a migration assistant to try and save some large downloads to people. It runs only once even if it fails, as the worst thing that can happen is that you need to redownload compilers to the new location, so I prefer not to risk it interfering unexpectedly. |
We fixed the cache path in #1265 but the deployer of binary releases was defaulting to the config location.