Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the cache location for shared releases #1349

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

mosteo
Copy link
Member

@mosteo mosteo commented Mar 14, 2023

We fixed the cache path in #1265 but the deployer of binary releases was defaulting to the config location.

@mosteo mosteo marked this pull request as ready for review March 14, 2023 19:11
@mosteo mosteo marked this pull request as draft March 14, 2023 19:12
@mosteo mosteo marked this pull request as ready for review March 14, 2023 20:20
@mosteo mosteo requested a review from Fabien-Chouteau March 14, 2023 20:20
Copy link
Member

@Fabien-Chouteau Fabien-Chouteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be worth adding a test.

@mosteo
Copy link
Member Author

mosteo commented Mar 16, 2023

I thought about it, but all of our tests are running with custom config to avoid getting contaminated by the user config. So in a way it's being tested, but the default isn't.

I can't think an easy way of running a test with default environment short of using something like chroot... Do you have any ideas?

@Fabien-Chouteau
Copy link
Member

I forgot about the custom config for the testsuite. I don't have a solution to offer...

@mosteo
Copy link
Member Author

mosteo commented Mar 20, 2023

I've got a solution for testing with default config but that will be in a separate PR as it's not trivial.

In this one I've added a migration assistant to try and save some large downloads to people. It runs only once even if it fails, as the worst thing that can happen is that you need to redownload compilers to the new location, so I prefer not to risk it interfering unexpectedly.

@mosteo mosteo requested a review from Fabien-Chouteau March 20, 2023 12:05
@mosteo mosteo requested a review from Fabien-Chouteau March 21, 2023 11:18
@mosteo mosteo merged commit 412f297 into alire-project:master Mar 21, 2023
@mosteo mosteo deleted the fix/cache-loc branch March 21, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants