Update msys2 installer #1284
Merged
Update msys2 installer #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's the Since there's also this problem with |
|
This is vexing because IIRC I added that second update precisely to survive some other msys2 problems. Oh well. |
|
I think I've got the solution. Push incoming. |
mosteo
force-pushed
the
update-msys2-installer
branch
from
f3a2c7c to
25b8ef6
Compare
|
The remaining failure is because the self-build is done with the latest release, which doesn't contain the fix. So I think we're good to go. |
|
@Fabien-Chouteau, for some reason I cannot add you directly as reviewer. If you can take a look at the PR, thanks! |
|
Because I am the author of the PR. Also I can't approve the PR. |
|
Oh right... |
mosteo
approved these changes
Jan 12, 2023
mosteo
added a commit
to mosteo/alire
that referenced
this pull request
Jan 12, 2023
* Update msys2 installer * Follow updated MSYS2 first install instructions * Show proper error message if msys2 update fails * Fix the command to query for pending updates * Don't scare-warn needlessly during msys2 update Co-authored-by: Alejandro R. Mosteo <amosteo@unizar.es>
mosteo
added a commit
that referenced
this pull request
Jan 12, 2023
* Update msys2 installer (#1284) * Update msys2 installer * Follow updated MSYS2 first install instructions * Show proper error message if msys2 update fails * Fix the command to query for pending updates * Don't scare-warn needlessly during msys2 update Co-authored-by: Alejandro R. Mosteo <amosteo@unizar.es> * Bump version to 1.2.2 Co-authored-by: Fabien Chouteau <Fabien-Chouteau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.