Fix crate config conflicts errors #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
force-pushed
the
fix_crate_config_conflicts_errors
branch
from
2cef73b to
0cab969
Compare
To match casing of TOML files where they come from.
- TOML value comparison was incorrect (use Equals function now) - The "set by" info was incorrect - Error message now show the conflicting values
Fabien-Chouteau
force-pushed
the
fix_crate_config_conflicts_errors
branch
from
0cab969 to
0e9ce57
Compare
mosteo
approved these changes
Nov 18, 2022
|
Thanks @mosteo , we should merge this in the |
Fabien-Chouteau
added a commit
that referenced
this pull request
Nov 18, 2022
* Alire.Properties.Configurations: print boolean values in lowercase To match casing of TOML files where they come from. * Alire.Crate_Configuration: fix, improve, and test value conflicts - TOML value comparison was incorrect (use Equals function now) - The "set by" info was incorrect - Error message now show the conflicting values
mosteo
pushed a commit
that referenced
this pull request
Nov 18, 2022
* Fix crate config conflicts errors (#1208) * Alire.Properties.Configurations: print boolean values in lowercase To match casing of TOML files where they come from. * Alire.Crate_Configuration: fix, improve, and test value conflicts - TOML value comparison was incorrect (use Equals function now) - The "set by" info was incorrect - Error message now show the conflicting values * Set macOS version to 10.15 for CI To avoid compiler issue with Xcode 14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.