Speed-up detection of installed externals in RPM-based distros #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fabien-Chouteau
previously approved these changes
Jun 3, 2022
Although the yum/dnf wrappers are needed for the installation proper, we can speed up detections of already installed packages by using rpm directly. Unfortunately, rpm cannot give info on not installed packages, but this still speeds up things greatly for the usual case of gnat/gprbuild being installed.
Hello, I don't see any problems in this new implementation. |
|
Thanks, @BeChris |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the yum/dnf wrappers are needed for the installation proper, we can
speed up detections of already installed packages by using rpm directly.
Unfortunately, rpm cannot give info on not installed packages, but this still
should speed up things greatly for the usual case of gnat/gprbuild being installed.
Fixes #1028
@BeChris, as you did the original implementation, would you be so kind to check if you see any obvious problem with these changes?