Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No such file or directory during fonts backup #217

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

robbixc
Copy link
Contributor

@robbixc robbixc commented Jan 14, 2019

Hey there :)
During backup execution (with -all flag) I get No such file or directory on the fonts directory, which apparently doesn't exist on my system.
So here's the fix that simply check if the dir exists before doing anything

Hope it helps and thanks for this very useful tool!

@alichtman
Copy link
Owner

Hey there! Thanks for reporting this.

Can you give me some information about your setup (OS, shallow-backup version, etc.)?

How do you not have a fonts directory? Is this on an ssh-only/no-graphics system?

@robbixc
Copy link
Contributor Author

robbixc commented Jan 15, 2019

Sure!
I'm running shallow_backup-2.3 on a freshly installed ubuntu 18.10 and there is definitely no ~/.fonts dir
Regardless of the system I think it is a good a idea to have a check in place so the software won't break over OS changes
Let me know if there is anything else I can do to help :)

@alichtman
Copy link
Owner

Yep, the ~/.fonts dir is optional. Good catch.

Regardless of the system I think it is a good a idea to have a check in place so the software won't break over OS changes

Agreed.

Copy link
Owner

@alichtman alichtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix codacy issue and then I'll merge.

@alichtman
Copy link
Owner

Let's add a log statement saying that font backup is being skipped or something.

shallow_backup/backup.py Outdated Show resolved Hide resolved
@alichtman alichtman merged commit 0aeec79 into alichtman:master Jan 15, 2019
@alichtman
Copy link
Owner

Thanks for the contribution, @robbixc!

@uhve uhve mentioned this pull request May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants