gitpython Not Installed Automatically w/ setup.py

[AlexanderProd]

I've installed shallow-backup using pip3
$ pip3 install shallow-backup

But running shallow-backup throws this error

Traceback (most recent call last):
  File "/usr/local/bin/shallow-backup", line 7, in <module>
    from shallow_backup.__main__ import cli
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/__main__.py", line 3, in <module>
    from .prompts import *
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/prompts.py", line 7, in <module>
    from .git_wrapper import git_set_remote, move_git_repo
  File "/usr/local/lib/python3.7/site-packages/shallow_backup/git_wrapper.py", line 3, in <module>
    import git
ModuleNotFoundError: No module named 'git'

I've got git installed and it is working on my mac though.
Python3 is installed via brew.

Python version: 3.7.1
pip3: 18.1
macOS: 10.14.2

[alichtman]

This is a seemingly confusing error with an easy fix. It's not saying you're missing git, it's saying you're missing a package called gitpython which has a module named git.

To fix this on your machine

You should run pip3 install gitpython, however, this should be installed automatically when you run pip3 install shallow-backup.

I'm filing this as a bug, and I'll look into fixing it when I have some time.

To fix this in the repo

The error is in this section:

shallow-backup/setup.py

Line 60 in bdd0d32

install_requires=[

One line is missing, which would install gitpython automatically. Do you want to make the change, see if it works for you, and then send a PR to fix it in the repo?

I'd normally do it myself, but it's finals week and I don't have a ton of time right now.

[AlexanderProd]

Thanks this fixed it and I've opened a PR including the changes.

[alichtman]

Awesome, thanks man.