Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] Replace desc.Node.internalFolder with {nodeCacheFolder} #2693

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

cbentejac
Copy link
Contributor

Description

This PR is a follow-up to #2629 and replaces desc.Node.internalFolder (which has been removed) with {nodeCacheFolder} for nodes that were added right before the merge of #2629.

For nodes that were added right before the merge of #2629, the replacement
still needed to be done.
@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Mar 10, 2025
@cbentejac cbentejac self-assigned this Mar 10, 2025
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.39%. Comparing base (21afd05) to head (091dbdd).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2693   +/-   ##
========================================
  Coverage    73.39%   73.39%           
========================================
  Files          133      133           
  Lines         7911     7911           
========================================
  Hits          5806     5806           
  Misses        2105     2105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiencastan fabiencastan merged commit 08614a3 into develop Mar 10, 2025
5 checks passed
@fabiencastan fabiencastan deleted the dev/relativePathsUpdate branch March 10, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants