Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] AttributeEditor: Generic TextField param editor improvements #2686

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

yann-lty
Copy link
Member

Description

This PR improves the UX for the generic TextField editor used for String/File params.

Before
image
After
image

Features list

  • Show text cursor on hover.
  • Use disabled text color when the control is readOnly.

* Use disabled text color when attribute is readonly.
* Improved UX: text cursor on mouse hovering.
* Simplify context menu handling.
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (f901f81) to head (6341975).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2686   +/-   ##
========================================
  Coverage    72.83%   72.83%           
========================================
  Files          130      130           
  Lines         7763     7763           
========================================
  Hits          5654     5654           
  Misses        2109     2109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-lty yann-lty requested a review from cbentejac February 26, 2025 15:34
@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Feb 27, 2025
@cbentejac cbentejac merged commit 2f05261 into develop Feb 27, 2025
5 checks passed
@cbentejac cbentejac deleted the fix/attributeEditorTextField branch February 27, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants