Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChoiceParam: add option to serialize overriden values #2682

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

yann-lty
Copy link
Member

Description

This PR extends the current behavior of ChoiceParam by allowing node developers to save the list of values if they have been overridden at runtime.

Features list

  • ChoiceParam: support for serialization of overridden list of possible values.

Implementation remarks

Introduce a new saveValuesOverride parameter on desc.ChoiceParam to define whether to serialize the list of possible values if they have been overridden at runtime.
If that is set to True, the ChoiceParam instance is serialized as a dictionary containing both the value and list of possible values.

Introduce a new `saveValuesOverride` parameter on desc.ChoiceParam to define
whether to serialize the list of possible values if they have been overridden at runtime.
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 99.13043% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.22%. Comparing base (8ee7b50) to head (062bc3c).
Report is 13 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
meshroom/core/attribute.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2682      +/-   ##
===========================================
+ Coverage    72.79%   73.22%   +0.43%     
===========================================
  Files          129      130       +1     
  Lines         7753     7863     +110     
===========================================
+ Hits          5644     5758     +114     
+ Misses        2109     2105       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yann-lty yann-lty requested review from cbentejac and waaake February 21, 2025 10:08
@yann-lty yann-lty marked this pull request as ready for review February 21, 2025 19:27
@cbentejac cbentejac added this to the Meshroom 2025.1.0 milestone Feb 27, 2025
@cbentejac cbentejac merged commit 5791bdb into develop Mar 5, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/choiceParamValuesOverride branch March 5, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants