[HDR] Update the scale constraint #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
fcastan
force-pushed
the
dev/debugDebevec
branch
from
7ec0624 to
ef478d1
Compare
…h non-pinhole cameras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debevec calibration needs an additional constraint to fix a degree of freedom.
We previously used that f(1) = 0 for all channels. But this caused problem on some dataset as the maximal value is different between channels.
This PR use f(0.5) = 0, which is the original constraint (as per the paper). We used f(1) = 0 for numerical stability in some tests.
This is a major update to the debevec update. All sequences should be tested.