Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Matching] fix unmatching declaration and definitions #810

Merged
merged 2 commits into from
Jun 16, 2020
Merged

[Matching] fix unmatching declaration and definitions #810

merged 2 commits into from
Jun 16, 2020

Conversation

simogasp
Copy link
Member

There were several functions that had a different signature declaration between declaration and definition. (i.e. some API were not implemented)

@simogasp simogasp added this to the 2020.1.0 milestone Jun 12, 2020
@simogasp simogasp requested a review from fabiencastan June 12, 2020 17:33
@fabiencastan fabiencastan requested a review from theoleplomb June 12, 2020 19:30
@fabiencastan fabiencastan merged commit 4d13542 into develop Jun 16, 2020
@fabiencastan fabiencastan deleted the matching/fixUnimplemented branch June 16, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoleplomb theoleplomb theoleplomb approved these changes

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simogasp @theoleplomb @fabiencastan