[Texturing] Improve texturing quality on (low-poly) user mesh after retopology #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesh keeps uvCoords, normals, pointsVisibilities,.. attributes
Remove function arguments which became redundant (knowing Mesh has new attributes)
First "level" of pointer removed !
override sizeOfStaticVector for object (instead of pointer)
use simple objects inside functions (instead of declaring & deleting pointers) and use references
Modify functions to subdivide a mesh to update uv coords, and use it to texture a simplified mesh. WARNING: for now, all meshes with uv coords are subdivided & mesh subdivision assumes that the mesh already has uv coords. The texturing of a subdivided mesh only works for meshes with one texture atlas
Update _atlases and _trisMtlIds when subdividing a mesh : add new triangles to the right atlas (++ _trisMtlIds is now a std::vector)
- new structure for edges - subdivision based only on edges length - main_texturing save the simplified & textured mesh
new criterion for subdividing an edge : the edge on the retopo mesh must be longer than the local mean of edges length in the reference mesh bug fix : texturing a retopo mesh after Meshroom's uv generation
fabiencastan
force-pushed
the
dev/texturing_retopomesh
branch
from
08ed5d4 to
b57b423
Compare
|
TODO: remove |
- remap visibilities from dense point cloud instead of dense mesh - remap visibilities after mesh subdivision
Change subdivision parameters to use only one parameter and ensure that we do not create more vertices than the reference mesh/pointcloud
fabiencastan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Subdivide a retopo mesh for texturing efficiency.
If a mesh has been simplified, we subdivide it with corresponding new uv coords. This enables to make more fine grain decision on the best visibilities to use per triangle to create the final texture.
The subdivision method is based on edges length and mesh number of points. We create texture atlases for the subdivided mesh. Then, we return the retopo mesh with these texture atlases.
Features list
Implementation remarks
Rewriting of already existing methods to subdivide a mesh.