Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SensorDB] ~100 models added #618

Merged
merged 2 commits into from
Jun 4, 2019
Merged

[SensorDB] ~100 models added #618

merged 2 commits into from
Jun 4, 2019

Conversation

natowi
Copy link
Member

@natowi natowi commented Mar 23, 2019

models added and list sorted

@natowi natowi changed the title ~100 models added [SensorDB] ~100 models added Mar 23, 2019
@fabiencastan
Copy link
Member

Hi,
Sorry for not merging that before!!
Have you used the script provided in the repository to sort the DB?
It seems that the sort used is not the same and creates many modifications for nothing, like inverting "AgfaPhoto;AgfaPhoto ePhoto CL30 Clik!" and "AgfaPhoto;AgfaPhoto ePhoto CL30".

@natowi
Copy link
Member Author

natowi commented Jun 4, 2019

@fabiencastan No, I was not aware of the sorting script

@fabiencastan
Copy link
Member

Could you re-process your file with the script?

@fabiencastan fabiencastan merged commit a379865 into alicevision:develop Jun 4, 2019
@fabiencastan
Copy link
Member

Thanks!

@fabiencastan fabiencastan added this to the 2019.2 milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregoire-dl gregoire-dl Awaiting requested review from gregoire-dl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2019.2
Development

Successfully merging this pull request may close these issues.
2 participants
@natowi @fabiencastan