Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

New collector for set metrics #3

Merged
merged 1 commit into from
Dec 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const (
systemNode = "node"
systemNamespace = "ns"
systemLatency = "latency"
systemSet = "set"
)

var (
Expand Down Expand Up @@ -92,6 +93,7 @@ func newAsCollector(nodeAddr string) *asCollector {
newStatsCollector(),
newNSCollector(),
newLatencyCollector(),
newSetCollector(),
},
}
}
Expand Down
10 changes: 6 additions & 4 deletions metric.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ func infoCollect(

func parseInfo(s string) map[string]string {
r := map[string]string{}
for _, v := range strings.Split(s, ";") {
kv := strings.SplitN(v, "=", 2)
if len(kv) > 1 {
r[kv[0]] = kv[1]
for _, l := range strings.Split(s, ";") {
for _, v := range strings.Split(l, ":") {
kv := strings.SplitN(v, "=", 2)
if len(kv) > 1 {
r[kv[0]] = kv[1]
}
}
}
return r
Expand Down
7 changes: 7 additions & 0 deletions metric_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ func TestParseInfo(t *testing.T) {
"version=my=version": {
"version": "my=version",
},
"ns=vk:set=user:objects=2501:memory_data_bytes=0:deleting=false": {
"ns": "vk",
"set": "user",
"objects": "2501",
"memory_data_bytes": "0",
"deleting": "false",
},
} {
if have, want := parseInfo(k), v; !reflect.DeepEqual(have, want) {
t.Errorf("have %+v, want %+v", have, want)
Expand Down
56 changes: 56 additions & 0 deletions sets.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
package main

import (
"log"
"strings"

as "github.com/aerospike/aerospike-client-go"
"github.com/prometheus/client_golang/prometheus"
)

var (
// SetMetrics lists the keys we report from aero's sets
// command.
// See `asinfo -l -v sets` for the full list.
SetMetrics = []metric{
gauge("objects", "objects"),
gauge("memory_data_bytes", "memory data bytes"),
counter("stop-writes-count", "stop writes count"),
}
)

type setCollector cmetrics

func newSetCollector() setCollector {
set := map[string]cmetric{}
for _, m := range SetMetrics {
set[m.aeroName] = cmetric{
typ: m.typ,
desc: prometheus.NewDesc(
promkey(systemSet, m.aeroName),
m.desc,
[]string{"namespace", "set"},
nil,
),
}
}
return set
}

func (setc setCollector) describe(ch chan<- *prometheus.Desc) {
for _, s := range setc {
ch <- s.desc
}
}

func (setc setCollector) collect(conn *as.Connection, ch chan<- prometheus.Metric) {
info, err := as.RequestInfo(conn, "sets")
if err != nil {
log.Print(err)
return
}
for _, setInfo := range strings.Split(info["sets"], ";") {
setStats := parseInfo(setInfo)
infoCollect(ch, cmetrics(setc), setInfo, setStats["ns"], setStats["set"])
}
}