chore(documentation): improve match handler documentation from issue #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Artalus
reviewed
May 11, 2023
docs/usage/detail.md
Outdated
Comment on lines
286
to
287
| If are using `Result(success="my_success")` and `Result(failure=NoSuchKey())` syntaxis intead of recommended one | ||
| with `Success` and `Failure` alias, you have to use a different match pattern. |
There was a problem hiding this comment.
syntaxis->syntax?alias->aliases?
docs/usage/detail.md
Outdated
Comment on lines
297
to
298
| Result("Failure with TypeMismatch") |
There was a problem hiding this comment.
Suggested change
| case Failure(_, TypeMismatch()): | |
| Result("Failure with TypeMismatch") | |
| case Result(_, TypeMismatch()): | |
| print("Failure with TypeMismatch") |
acostapazo
deleted the
56-match-syntax-fails-when-used-with-raw-result-instead-of-failuresuccess
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.