-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #12970] Fix NamingMetadataManager.removeInstanceMetadata() error #12971
Conversation
[ISSUE alibaba#12970] Fix NamingMetadataManager.removeInstanceMetadata() error
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12971 +/- ##
=============================================
- Coverage 72.27% 72.27% -0.01%
Complexity 9997 9997
=============================================
Files 1309 1309
Lines 41991 41991
Branches 4405 4405
=============================================
- Hits 30349 30348 -1
- Misses 9516 9517 +1
Partials 2126 2126
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
|
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
fix #12970
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.