Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix labels from env #12604

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix labels from env

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.65%. Comparing base (821150d) to head (37929a1).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...cos/common/labels/impl/DefaultLabelsCollector.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12604      +/-   ##
=============================================
+ Coverage      69.62%   69.65%   +0.03%     
- Complexity      9409     9422      +13     
=============================================
  Files           1275     1275              
  Lines          41213    41232      +19     
  Branches        4370     4374       +4     
=============================================
+ Hits           28694    28721      +27     
+ Misses         10437    10431       -6     
+ Partials        2082     2080       -2     
Files with missing lines Coverage Δ
...cos/common/labels/impl/DefaultLabelsCollector.java 68.08% <50.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821150d...37929a1. Read the comment docs.

@KomachiSion KomachiSion merged commit feb4c09 into alibaba:develop Sep 5, 2024
7 checks passed
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Sep 5, 2024
@KomachiSion KomachiSion added this to the 2.4.2 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants